Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #6429: Fix errors from using published datasets #6473

Closed
wants to merge 1 commit into from

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Nov 18, 2014

This pull request fixes two errors in the All In One Validation Tool's interface to DAS, which currently does not function at all, requiring an extra step in specifying the data files to use.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_0_X.

Backport of #6429: Fix errors from using published datasets

It involves the following packages:

Alignment/OfflineValidation

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #6473 was updated. @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please check and sign again.

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Nov 27, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@hroskes
Copy link
Contributor Author

hroskes commented Jul 1, 2015

Should I close this?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2015

This branch is closed for updates. Closing this pull request.
Please bring this up in the ORP meeting if really needed.

@cmsbuild cmsbuild closed this Jul 1, 2015
@hroskes hroskes deleted the fix-dataset-error-70X branch July 1, 2015 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants