New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing spurious error message from GsfElectron::ecalDriven() #6479
Conversation
…Prelection flag is not being filled in 7X and is not an issue
A new Pull Request was created by @Sam-Harper for CMSSW_7_3_X. removing spurious error message from GsfElectron::ecalDriven() It involves the following packages: DataFormats/EgammaCandidates @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
removing spurious error message from GsfElectron::ecalDriven()
The flags passPflowPreselection_ and passMvaPreslection_ [sic] are not being filled in 7X. This creates a spurious error message in GsfElectron::ecalDriven() which does a sanity check on whether any preselection was passed. As passMvaPreslection_ is always false, this fails when the electron does not pass the cut based preselection and this causes the error message to print out. The message is harmless, the function returns exactly the correct value, it just alerted us to this issue. We will shortly port the same fix to 72X.
In 73X or 74X, we will actually fill the flags although on closer inspection passPflowPreselection_ is fully redundant with mvaOutput.status. In theory passMvaPreslection_ is also redundant as you have the mva variables used to cut on but this cut value could change in time so its probably worth keeping it around to avoid accidents. We will not port this to 72X unless requested as the samples have been produced and therefore this will have no effect.