Changes in the CondFormat (Only) necessary for migration to 6x6 APE

[ASvyatkovskiy]

Pull request contains the changes i the CondFormat (only) necessary for migration to 6x6 APEs. The pull request is a subset of the earlier PR, containing these files only:
https://github.com/cms-sw/cmssw/pull/6420/files#diff-124
https://github.com/cms-sw/cmssw/pull/6420/files#diff-169

An extra change (bug fix) in the record mapping is done (CondCore/AlignmentPlugins/src/plugins.cc):

REGISTER_PLUGIN(TrackerAlignmentErrorRcd,AlignmentErrors);
L61
REGISTER_PLUGIN(DTAlignmentErrorRcd,AlignmentErrors);
L64
REGISTER_PLUGIN(CSCAlignmentErrorRcd,AlignmentErrors);
L66

Tested locally under CMSSW_7_3_X_2014-11-18-0200 with runTheMatrix, here is the output: 1 1 1 1 tests passed, 0 0 0 0 failed

[cmsbuild]

A new Pull Request was created by @ASvyatkovskiy (Alexey Svyatkovskiy) for CMSSW_7_3_X.

Changes in the CondFormat (Only) necessary for migration to 6x6 APE

It involves the following packages:

CondCore/AlignmentPlugins
CondFormats/Alignment
CondFormats/AlignmentRecord

@apfeiffer1, @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[apfeiffer1]

+1

On Tue, Nov 18, 2014 at 8:11 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @ASvyatkovskiy
https://github.com/ASvyatkovskiy (Alexey Svyatkovskiy) for CMSSW_7_3_X.

Changes in the CondFormat (Only) necessary for migration to 6x6 APE

It involves the following packages:

CondCore/AlignmentPlugins
CondFormats/Alignment
CondFormats/AlignmentRecord

@apfeiffer1 https://github.com/apfeiffer1, @nclopezo
https://github.com/nclopezo, @cerminar https://github.com/cerminar,
@cmsbuild https://github.com/cmsbuild, @diguida
https://github.com/diguida, @rcastello https://github.com/rcastello,
@ggovi https://github.com/ggovi, @mmusich https://github.com/mmusich
can you please review it and eventually sign? Thanks.
@ghellwig https://github.com/ghellwig this is something you requested
to watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@nclopezo https://github.com/nclopezo you are the release manager for
this.
You can merge this pull request by typing 'merge' in the first line of
your comment.

—
Reply to this email directly or view it on GitHub
#6483 (comment).

Thanks,
cheers, andreas

[diguida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1

[davidlange6]

breaks the IB - will revert for now

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc491/CMSSW_7_3_X_2014-11-19-1400/pyRelValMatrixLogs/run/531.0_ReggeGribovPartonMC_EposLHC_5TeV_pPb+ReggeGribovPartonMC_EposLHC_5TeV_pPb+HARVESTGEN/step1_ReggeGribovPartonMC_EposLHC_5TeV_pPb+ReggeGribovPartonMC_EposLHC_5TeV_pPb+HARVESTGEN.log

[diguida]

@davidlange6 I think I found the bug.
Ok to revert for now, will do another PR with the fix.

[davidlange6]

Hi Salvatore
I guess the bug can just be what I fixed in #6503, or is there more?

On Nov 20, 2014, at 9:30 AM, Salvatore Di Guida notifications@github.com
wrote:

@davidlange6 I think I found the bug.
Ok to revert for now, will do another PR with the fix.

—
Reply to this email directly or view it on GitHub.

[diguida]

@davidlange6 That's correct.
I suppose something went wrong when committing the plugin file: as you can see in the description #6483 (comment), I asked to revert the change in line 61 but actually the line was deleted, while the other two changes in line 64 and line 66 are correctly done. Interesting that the local and short matrix test in Jenkins were ok...

[davidlange6]

On Nov 20, 2014, at 9:50 AM, Salvatore Di Guida notifications@github.com
wrote:

@davidlange6 That's correct.
I suppose something went wrong when committing the plugin file: as you can see in the description #6483 (comment), I asked to revert the change here

cmssw/CondCore/AlignmentPlugins/src/plugin.cc

Line 61 in c0e783c

REGISTER_PLUGIN(TrackerAlignmentErrorRcd,AlignmentErrorsExtended);

but actually the line was deleted, while the other two changes in L64 and L66 are correctly done. Interesting that the local matrix test were ok…

presumably the plugin was picked up from the base release in local testing...

—
Reply to this email directly or view it on GitHub.