Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

72X - fix HadronAndPartonSelector for unknown generators #6485

Merged
merged 1 commit into from
Nov 19, 2014
Merged

72X - fix HadronAndPartonSelector for unknown generators #6485

merged 1 commit into from
Nov 19, 2014

Conversation

vadler
Copy link

@vadler vadler commented Nov 18, 2014

A possibly invalid handle in the HadronAndPartonSelector is not dereferenced any more, before its validity has been checked.

@vadler vadler mentioned this pull request Nov 18, 2014
Merged
@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Nov 18, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_7_2_X.

72X - fix HadronAndPartonSelector for unknown generators

It involves the following packages:

PhysicsTools/JetMCAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vadler
Copy link
Author

vadler commented Nov 18, 2014

+1
Tested with CMSSW_7_2_X_2014-11-18-0200.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: c96e858
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6485/986/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6485/986/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 19, 2014
@davidlange6
Merge pull request #6485 from vadler/72X-fixHadronAndPartonSelectorFo…
0fef928 
…rUnknownGenerators

72X - fix `HadronAndPartonSelector` for unknown generators
@davidlange6 davidlange6 merged commit 0fef928 into cms-sw:CMSSW_7_2_X Nov 19, 2014
@vadler vadler deleted the 72X-fixHadronAndPartonSelectorForUnknownGenerators branch November 19, 2014 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available fully-signed orp-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.
3 participants
@vadler @cmsbuild @davidlange6