Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making CMVA in standard Reco IVF-based #6499

Conversation

ferencek
Copy link
Contributor

In 7_2_X CMVA in PAT was IVF-based but the Reco version wasn't. This PR synchronizes the two versions and makes them both IVF-based.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_3_X.

Making CMVA in standard Reco IVF-based

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTau/JetTagComputer

@nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @acaudron, @mmarionncern, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@ferencek
Copy link
Contributor Author

CMVA is not yet included in the b-tag validation but discriminators are included in the standard Reco (https://github.com/cms-sw/cmssw/blob/CMSSW_7_3_X/RecoBTag/Configuration/python/RecoBTag_cff.py#L39) and stored in the RECO/AOD output. As Volker reported above, small differences in the CMVA output are expected.

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants