Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subjets in PAT btag example #6500

Conversation

ferencek
Copy link
Contributor

Added pruned subjets of ca8PFJetsCHS to the PAT btag example to enable monitoring of the jet flavor, explicit JTA, and SV clustering for subjets. This is a follow-up to #6417

…flavor, explicit JTA, and SV clustering for subjets
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_3_X.

Subjets in PAT btag example

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @acaudron, @mmarionncern, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1

Tested at: 31716ca
I ran the usual tests and I found errors in the following unit tests:

---> test TestFWCoreIntegrationStandalone had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6500/1011/summary.html

@cmsbuild
Copy link
Contributor

@ferencek
Copy link
Contributor Author

Errors are unrelated to the code changes.

@vadler
Copy link

vadler commented Nov 20, 2014

@cmsbuild : Please re-run the tests

@vadler
Copy link

vadler commented Nov 20, 2014

+1
Tested with CMSSW_7_3_X_2014-11-20-0200 + #6503 .

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 20, 2014
…CMSSW_7_3_X_2014-11-19-1400

Subjets in PAT btag example
@davidlange6 davidlange6 merged commit ef87a07 into cms-sw:CMSSW_7_3_X Nov 20, 2014
@ferencek ferencek deleted the SubjetsPATBTagExample_from-CMSSW_7_3_X_2014-11-19-1400 branch November 20, 2014 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants