Fix file case issue on macosx.

[ktf]

The issue here is that btagsf.py and BTagSF.py, which is in the same directory, differ only in case. Mac is case insensitive so this makes the two file being effectively the same, breaking stuff. For the moment I simply renamed it and adapted CMSSW code using it. Feel free to propose a better solution.

@cbernet

[cmsbuild]

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_3_X.

Fix file case issue on macosx.

It involves the following packages:

PhysicsTools/Heppy

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cbernet]

Thanks for the fix, Giulio.
The problem is that btagsf.py (now btagsf_lowercase.py) shouldn’t be there, as it’s just a copy of BTagSF.py.
I’ll take the occasion of my next pull request to remove btagsf_lowercase.py and keep only BTagSF.py

Cheers,

Colin

Le 20 nov. 2014 à 12:01, Giulio Eulisse notifications@github.com a écrit :

The issue here is that btagsf.py and BTagSF.py, which is in the same directory, differ only in case. Mac is case insensitive so this makes the two file being effectively the same, breaking stuff. For the moment I simply renamed it and adapted CMSSW code using it. Feel free to propose a better solution.

@cbernet

You can merge this Pull Request by running

git pull https://github.com/ktf/cmssw fix-heppy
Or view, comment on, or merge it at:

#6507

Commit Summary

Fix file case issue on macosx.
File Changes

M PhysicsTools/Heppy/python/analyzers/examples/JetAnalyzer.py (2)
R PhysicsTools/Heppy/python/physicsutils/btagsf_lowercase.py (0)
Patch Links:

https://github.com/cms-sw/cmssw/pull/6507.patch
https://github.com/cms-sw/cmssw/pull/6507.diff
—
Reply to this email directly or view it on GitHub.

[ktf]

Yes, that's what I suspected. However since JetAnalyzer.py I decided to
keep it.

On Fri Nov 21 2014 at 10:09:46 AM Colin Bernet notifications@github.com
wrote:

Thanks for the fix, Giulio.
The problem is that btagsf.py (now btagsf_lowercase.py) shouldn’t be
there, as it’s just a copy of BTagSF.py.
I’ll take the occasion of my next pull request to remove
btagsf_lowercase.py and keep only BTagSF.py

Cheers,

Colin

Le 20 nov. 2014 à 12:01, Giulio Eulisse notifications@github.com a
écrit :

The issue here is that btagsf.py and BTagSF.py, which is in the same
directory, differ only in case. Mac is case insensitive so this makes the
two file being effectively the same, breaking stuff. For the moment I
simply renamed it and adapted CMSSW code using it. Feel free to propose a
better solution.

@cbernet

You can merge this Pull Request by running

git pull https://github.com/ktf/cmssw fix-heppy
Or view, comment on, or merge it at:

#6507

Commit Summary

Fix file case issue on macosx.
File Changes

M PhysicsTools/Heppy/python/analyzers/examples/JetAnalyzer.py (2)
R PhysicsTools/Heppy/python/physicsutils/btagsf_lowercase.py (0)
Patch Links:

https://github.com/cms-sw/cmssw/pull/6507.patch
https://github.com/cms-sw/cmssw/pull/6507.diff
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#6507 (comment).