Prepare for taking MF configurations from DB #6514
Conversation
…he geometry that is dumped to DB
|
A new Pull Request was created by @namapane (Nicola Amapane) for CMSSW_7_3_X. Prepare for taking MF configurations from DB It involves the following packages: CondFormats/MFObjects @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @StoyanStoynev, @slava77, @mmusich can you please review it and eventually sign? Thanks. |
|
-1 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMC/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMC.log ----- Begin Fatal Exception 21-Nov-2014 10:18:07 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=NjettinessAdder label='Njettiness' Exception Message: MissingParameter: Parameter 'measureDefinition' not found. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
|
This PR is not related to anything relayed to "NjettinessAdder" nor it Nicola On 21-Nov-14 10:18, cmsbuild wrote:
|
|
So this is a feature introduced by @davidlange6 in an unrelated commit: c8cc267#diff-248d253292a18c6b288e1ce71fe60d82 it seems it breaks the tests, because as far as I can tell it requires a change in config parameters for runTheMatrix. Can you please fix this so that we can move on? |
|
think of my commit as partly fixing a problem rather than completely fixing it. The complete fix is now in the IB being built and the failure won't hold up this PR On Nov 21, 2014, at 12:32 PM, Nicola Amapane notifications@github.com
|
| #ifdef MF_DEBUG | ||
| { | ||
| MagVolume6Faces* mv = static_cast<MagVolume6Faces*> (*ivol); | ||
| cout << " Trying volume " << mv->volumeNo << " " << int(mv->copyno) << endl; |
There was a problem hiding this comment.
cout is not recommended (including due to thread-safety considerations), there are the various LogMessages available. I suppose at some point there will be a campaign to clean the code but we can at least avoid introducing more to clean.
There was a problem hiding this comment.
this is in a #ifdef, and needs to stay like this, because this debug mode activates additional checks that need not to be run in production.
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
This has now been merged into CMSSW_7_4_X by #6602. Please close this if you do not plan to backport it to CMSSW_7_3_X. |
|
OK, assuming this won't be needed in 73X at this point, I close it. Thanks for taking care of 74X. |
Includes:
-Tools to create .db files for standard configurations
-Fix for one numerical stability problem with geometries imported to DB. The problem did not affect existing configurations (with geometry coming from xml), and the fix was regression-tested.
This fix is needed to be able to finally switch to reading MF geometry and configuration from DB, which will happen in a future (pre)release once a GT with all required payloads becomes available.