Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: remove hard-coded use of sqlite file and enable parallel offlin... #6536

Merged

Conversation

tlampen
Copy link
Contributor

@tlampen tlampen commented Nov 21, 2014

...e validation for cosmics.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tlampen (Tapio Lampén) for CMSSW_7_3_X.

BUG FIX: remove hard-coded use of sqlite file and enable parallel offlin...

It involves the following packages:

Alignment/OfflineValidation

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

-1
@tlampen This pull request is cannot be automatically merged, could you please rebase it?

@mmusich
Copy link
Contributor

mmusich commented Nov 27, 2014

@cmsbuild @diguida:
@frmeier @tlampen and me are puzzled by the -1. Wasn't this PR already merged? I can see it in the log of the latest IB....

@diguida
Copy link
Contributor

diguida commented Nov 27, 2014

@mmusich I think it was a glitch of the bot. The merging happened 3 days ago, the un-mergeability was yesterday...

cmsbuild added a commit that referenced this pull request Dec 3, 2014
…ics_for72X

Backport of #6536: BUG FIX: remove hard-coded use of sqlite file and enable parallel offlin...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants