fix to run Z->mumu alignment validation

[scasasso]

Some fixes to run the Z->mumu alignment validation on 72X and SLC6 machines

[cmsbuild]

A new Pull Request was created by @scasasso (Stefano Casasso) for CMSSW_7_2_X.

fix to run Z->mumu alignment validation

It involves the following packages:

Alignment/OfflineValidation

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: d175169
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6557/1107/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6557/1107/summary.html

[diguida]

@scasasso the fix is quite trivial:

• changing the reference for ZMuMu validation with ideal alignment;
• using the NavigationSchool for track refitting: it allows to update in the refit the expected inner hits and expected outer hits arrays (as Bugfix for cosmic track splitting alignment validation #6247 does);
• using the pileup information;
• using a most recent ROOT version (see my comment in the code).
  Can you also forward port it to 73X?

[diguida]

@scasasso do you really need to setup gcc and ROOT from LCG distributions on afs?
Cannot you use the ones embedded into CMSSW environment?

[scasasso]

This setup was inherited by the previous maintainers of the code.
I am not sure about gcc, but RooFit sometimes has problems if one does not use the LCG distribution...

[davidlange6]

I would be quite interested to know what problems have been encountered? Mixing gcc/root from lcg and cmssw is not a good idea and not needed

[mmusich]

@davidlange6 @diguida @scasasso
The gcc setup can be probably discarded (I suspect comes from MuonAnalysis calibration code)
As far as I can understand from @scasasso ROOT from cvmfs, i.e. in this case:
cvmfs/cms.cern.ch/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_2_1/external/slc6_amd64_gcc481/bin/root
does not provide RooFit while ROOT from lcg does.
Please correct me if I misunderstood.

[davidlange6]

On Dec 3, 2014, at 11:47 AM, Marco Musich notifications@github.com
wrote:

In Alignment/OfflineValidation/python/TkAlAllInOneTool/zMuMuValidationTemplates.py:

@@ -240,8 +243,8 @@

ls -lh .

-source /afs/cern.ch/sw/lcg/external/gcc/4.6.2/x86_64-slc5/setup.sh
-source /afs/cern.ch/sw/lcg/app/releases/ROOT/5.32.00/x86_64-slc5-gcc46-opt/root/bin/thisroot.sh
+source /afs/cern.ch/sw/lcg/external/gcc/4.8.1/x86_64-slc6/setup.sh
+source /afs/cern.ch/sw/lcg/app/releases/ROOT/5.34.10/x86_64-slc6-gcc48-opt/root/bin/thisroot.sh

@davidlange6 @diguida @scasasso
The gcc setup can be probably discarded (I suspect comes from MuonAnalysis calibration code)
As far as I can understand from @scasasso ROOT from cvmfs, i.e. in this case:
cvmfs/cms.cern.ch/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_2_1/external/slc6_amd64_gcc481/bin/root
does not provide RooFit while ROOT from lcg does.
Please correct me if I misunderstood.

See:

https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideRooFit

dlange@cmsdev01 CMSSW_7_2_1]$ scram tool info roofit
Tool info as configured in location /build/dlange/CMSSW_7_2_1
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Name : roofit
Version : 5.34.18-cms11

RooFit is widely used in cms, so I doubt it is missing in any release.

—
Reply to this email directly or view it on GitHub.

[mmusich]

@davidlange6. Thanks for the link.I meant that invoking CompareBiasZValidation.C from CINT here just after a plain cmsenv fails.@scasasso My take is that this calls for having the RooFit application built from CMSSW as explained here: https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideRooFitCMSSW

[davidlange6]

maybe its best to post the error you get and a recipe to hyper news..

On Dec 3, 2014, at 12:25 PM, Marco Musich notifications@github.com
wrote:

In Alignment/OfflineValidation/python/TkAlAllInOneTool/zMuMuValidationTemplates.py:

@davidlange6. Thanks for the link.I meant that invoking CompareBiasZValidation.C from CINT here just after a plain cmsenv fails.@scasasso My take is that this calls for having the RooFit application built from CMSSW as explained here: https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideRooFitCMSSW

—
Reply to this email directly or view it on GitHub.

[scasasso]

I should have mentioned before, this is a backport of the fix recently introduced in 73X:
#6233 (comment)

[diguida]

+1
Same as #6233
TBC: RooFit issues in CMSSW.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1