Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for cosmic track splitting alignment validation #6247

Merged
merged 3 commits into from Nov 24, 2014
Merged

Bugfix for cosmic track splitting alignment validation #6247

merged 3 commits into from Nov 24, 2014

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Nov 6, 2014

These fixes are needed for the validation to run, because of 7X and other recent improvements.

Backport of #6244

@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Nov 6, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_2_X.

Bugfix for cosmic track splitting alignment validation

It involves the following packages:

Alignment/OfflineValidation

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

Pull request #6247 was updated. @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

+1
Tested at: c98c2e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6247/728/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6247/728/summary.html

@cmsbuild
Copy link
Contributor

Pull request #6247 was updated. @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please check and sign again.

@hroskes
Copy link
Contributor Author

hroskes commented Nov 24, 2014

@diguida Done (I think...) Did this work?
Also, should I do this for the other backports #6248 #6249 #6459?
Thanks!

@mmusich
Copy link
Contributor

mmusich commented Nov 24, 2014

+1
fixes configuration for Cosmic Track splitting validation

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 24, 2014
@davidlange6
Merge pull request #6247 from hroskes/track-splitting-72X-for-pullreq…
0b3b4f2 
…uest

Bugfix for cosmic track splitting alignment validation
@davidlange6 davidlange6 merged commit 0b3b4f2 into cms-sw:CMSSW_7_2_X Nov 24, 2014
@hroskes hroskes deleted the track-splitting-72X-for-pullrequest branch November 24, 2014 16:55
@diguida
Copy link
Contributor

diguida commented Nov 24, 2014

@hroskes yes, it worked.
For the other PR: if the other branch goes in before yours, you will get a merge conflict due to the merging in the tip of your branch.

@diguida diguida mentioned this pull request Nov 24, 2014
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: 0e1e3b4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6247/1110/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6247/1110/summary.html

@hroskes hroskes restored the track-splitting-72X-for-pullrequest branch December 8, 2014 15:02
@hroskes hroskes deleted the track-splitting-72X-for-pullrequest branch January 19, 2015 16:33
@hroskes hroskes restored the track-splitting-72X-for-pullrequest branch February 4, 2015 16:04
@hroskes hroskes deleted the track-splitting-72X-for-pullrequest branch February 4, 2015 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-pending fully-signed orp-pending tests-pending
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hroskes @cmsbuild @diguida @mmusich @davidlange6