New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CVS keywords from L1* #661
Remove CVS keywords from L1* #661
Conversation
A new Pull Request was created by @nclopezo (David Mendez) for CMSSW_7_0_X. Remove CVS keywords from L1* It involves the following packages: L1TriggerConfig/L1GtConfigProducers @mulhearn can you please review it and eventually sign? Thanks. |
@@ -10,7 +10,6 @@ | |||
* \author: Vasile Mihai Ghete - HEPHY Vienna | |||
* | |||
* $Date$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few "$Date$ which should be removed as well.
Yes, I see there are still some |
I hope so, but maybe tomorrow. |
No particular reason to wait actually. We can have a smaller request tomorrow |
OK I am attempting to merge and build it now... |
This is taking forever, at this last line, any idea what is going on? mulhearn@lxplus0378>cmsrel CMSSW_7_0_0_pre2
|
It seems I got the entire CMSSW repo when I used cms-merge-topic. What did I do wrong? |
Sorry, new guy here: so am I supposed to have my own build of cms_sw:CMSSW_7_0_X built, and then just test these changes against it? Or is there some way to select out only the packages listed above from nclopezo:remove-cvs-keywords-from-l1 and compile against e.g. CMSSW_7_0_0_pre2? Or am I just supposed to approve this because it only changed comments ;-) |
Hi @mulhearn You can use git cms-merge-topic 661, to get the changes on this pull request and test it. I updated my pull request deleting the |
As I see in the logs, everything compiled. |
Pull request #661 was updated. Signatures reset, please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
Thanks for doing the compile check on Jenkins and posting the log. If I wanted to compile a topic like this myself, e.g. for additional testing, is there a way I have access to the daily builds to compile against, or are those only available on Jenkins? |
Hi @mulhearn If you wanted to test on CMSSW_7_0_X_2013-08-29-1400 for example, you can run
instead of
and then cmsenv git cms-merge-topic 661 etc... |
Oh! I didn't see these in "scram list CMSSW" because of different architecture... Thanks! |
Spring16 MVA electron id
No description provided.