Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Castor geometry update #6617

Closed
wants to merge 2 commits into from
Closed

Castor geometry update #6617

wants to merge 2 commits into from

Conversation

cmsbuild
Copy link
Contributor

Overlap fixes and update for castor geometry.
Automatically ported from CMSSW_7_3_X #6277

Michael Eliachevitch added 2 commits November 7, 2014 04:27
- Included overlap fixes.
- Iemoved cuts from the low-eta of the corners of the ECAL-octants,
  which were unintentionally made because of too small boolean intersection boxes (C2EF/C3EF).
- Included cuts to the low eta corners, which weren't included in the previous geometries, but exist in the real geometry.
- Corrected the R-shift of the quartz/tungsten plates.
  It is implemented in order to create 1 mm steel frame on the plate sides, but was too large in the previous geometry definition.

Changes were presented at weekly offline meeting on 20 October 2014.
The slides can be found here: https://indico.cern.ch/event/344147/session/0/contribution/11/material/slides/0.pdf
@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_4_X.

Castor geometry update

It involves the following packages:

Geometry/ForwardCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ianna
Copy link
Contributor

ianna commented Nov 26, 2014

@davidlange6 - are we keeping run 2 geometry unchanged for 74x as well? If yes, this PR should be based on #6512 (which is still pending ORP approval)

@civanch
Copy link
Contributor

civanch commented Nov 26, 2014

@ianna yes, we need make it on top of #6512 as dev geometry

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

@ianna
Copy link
Contributor

ianna commented Dec 2, 2014

-1

@ktf - This PR should go in after #6512

@elimik31 - Geometry/ForwardCommonData/data/castor.xml should be moved to Geometry/ForwardCommonData/data/dev/castor.xml and the latter to be included in 2015dev scenario defined in #6512

@ktf
Copy link
Contributor

ktf commented Dec 2, 2014

If you depend on a pull request, please merge the associated branch in your own.

@civanch
Copy link
Contributor

civanch commented Dec 3, 2014

@elimik31, just now #6631 is merged, so it is possible to proceed with Castor geometry fixes on top of it. You need to move your modifications in castor.xml from current default place to development area: Geometry/CMSCommonData/data/dev/castor.xml. It is possible to modify this PR or create a new PR for 7_4_X.

@davidlange6
Copy link
Contributor

is this PR needed any longer?

@ianna ianna mentioned this pull request Jan 7, 2015
@davidlange6 davidlange6 closed this Jan 7, 2015
@ianna
Copy link
Contributor

ianna commented Jan 7, 2015

@davidlange6 - no, this one can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants