Removed asserts preventing fast re-recoes a la ECALELF

[cmsbuild]

The removal of asserts should not hurt, but prevents fast re-recoes
@lgray and cms-phys-conveners-EGM should probably double check ad approve

Automatically ported from CMSSW_7_3_X #6556

[cmsbuild]

A new Pull Request was created by @cmsbuild for CMSSW_7_4_X.

Removed asserts preventing fast re-recoes a la ECALELF

It involves the following packages:

DataFormats/EgammaCandidates

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[nclopezo]

+1
Latest commit marked as "Tests OK" in CMSSW_7_3_X

[StoyanStoynev]

This PR is being hold due to the discussion (or lack thereof) in #6556

[StoyanStoynev]

being held

[slava77]

better remove ctfInfo from the arguments list completely, these lines will then naturally go away.
This appears to be a fake variable preserved at some point to avoid the interface changes.

[slava77]

-1

The asserts are in place to enforce consistency of the ctf part between the GsfElectron constructor arguments, at least on the parts where GsfElectron and GsfElectronCore are the arguments.
Some of the asserts seem excessive though and I made a few comments in the code commits.

@shervin86 which of the asserts are your actual problem?
if it's the ones with const ClosestCtfTrack & ctfInfo, this could be circumvented trivially (although, I think the argument of the constructor itself better be removed in this case)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6625/2215/summary.html

[slava77]

+1

for #6625 8811538
checked locally in CMSSW_7_4_0_pre6 /test area sign500/
compiles and there are no differences in monitored quantities based on the short matrix tests

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.