Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

porting L1 code to new DQM interface #6627

Merged
merged 6 commits into from Dec 4, 2014
Merged

porting L1 code to new DQM interface #6627

merged 6 commits into from Dec 4, 2014

Conversation

cmsbuild
Copy link
Contributor

this PR supersedes #5996
@jingyucms

to be tested
Automatically ported from CMSSW_7_3_X #6533

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Nov 26, 2014
@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_4_X.

porting L1 code to new DQM interface

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient
DQMOffline/Configuration
DQMOffline/L1Trigger

@cmsbuild, @danduggan, @nclopezo, @mulhearn, @deguio can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@deguio
Copy link
Contributor

deguio commented Nov 26, 2014

+1

@nclopezo
Copy link
Contributor

+1
Latest commit marked as "Tests OK" in CMSSW_7_3_X

@deguio
Copy link
Contributor

deguio commented Dec 2, 2014

ping L1.
can this be approved and merged please? this is a huge PR.
thanks,
F.

@deguio
Copy link
Contributor

deguio commented Dec 4, 2014

@ktf @davidlange6
please consider bypassing the L1 signature and merge this one.
thanks,
F.

@ktf
Copy link
Contributor

ktf commented Dec 4, 2014

@mulhearn I'm bypassing your signature.

ktf added a commit that referenced this pull request Dec 4, 2014
@ktf
Merge pull request #6627 from deguio/PR_forL1
586ba48 
porting L1 code to new DQM interface
@ktf ktf merged commit 586ba48 into cms-sw:CMSSW_7_4_X Dec 4, 2014
@deguio
Copy link
Contributor

deguio commented Dec 4, 2014

thanks.. :)
ciao,
F.

@mulhearn
Copy link
Contributor

mulhearn commented Dec 4, 2014

+1 (for the record)

@mulhearn
Copy link
Contributor

mulhearn commented Dec 4, 2014

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending dqm-approved l1-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cmsbuild @deguio @nclopezo @ktf @mulhearn @jingyucms