New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix soft drop jet producer #6655
Conversation
A new Pull Request was created by @ahinzmann for CMSSW_7_3_X. Fix soft drop jet producer It involves the following packages: RecoJets/JetProducers @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
@ahinzmann this is fixing a problem observed where? What is the nature of the problem (I see some parameters are also changed)? |
The configuration parameter changes are to have CMS default parameters when softdrop and nsubjettiness are run in analyses. With the introduction of the new fastjet, the defaults were modified, and now back to what is used in analyses. |
I see no issues here but is this the only part in #6654 (74X) needed in 73X? |
All the other changes in the 74 request affect reco event content. Since the original request for the reco changes was closed in 73, I assume only non reco changes can still go in 73. If I understood correctly this request contains everything that is possible. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
Fix for the softdrop jet producer.
This is not run in 7_3_X RECO, but will be ran in analyses, so needs to be fixed.
The same fix has been requested for 7_4_X in #6654.