Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix soft drop jet producer #6655

Merged
merged 4 commits into from Nov 29, 2014
Merged

Conversation

ahinzmann
Copy link
Contributor

Fix for the softdrop jet producer.
This is not run in 7_3_X RECO, but will be ran in analyses, so needs to be fixed.
The same fix has been requested for 7_4_X in #6654.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for CMSSW_7_3_X.

Fix soft drop jet producer

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @yslai, @TaiSakuma, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@StoyanStoynev
Copy link
Contributor

@ahinzmann this is fixing a problem observed where? What is the nature of the problem (I see some parameters are also changed)?

@ahinzmann
Copy link
Contributor Author

The configuration parameter changes are to have CMS default parameters when softdrop and nsubjettiness are run in analyses. With the introduction of the new fastjet, the defaults were modified, and now back to what is used in analyses.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

I see no issues here but is this the only part in #6654 (74X) needed in 73X?

@ahinzmann
Copy link
Contributor Author

All the other changes in the 74 request affect reco event content. Since the original request for the reco changes was closed in 73, I assume only non reco changes can still go in 73. If I understood correctly this request contains everything that is possible.

@StoyanStoynev
Copy link
Contributor

+1
For 14e468c.
Jenkins show no diffs (as expected) and I also checked in QCD and ttbar samples (including miniAOD in wf 25202) that indeed there is nothing from this PR affecting the event content or performance. My tests were on top of CMSSW_7_3_X_2014-11-25-1400.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants