migration from EDProducer to stream::EDProducer (PixelVertexProducer)

[mtosi]

as reported by @fwyzard
https://docs.google.com/spreadsheets/d/1D9khDvOl05WEbznsUPCusEbrHeep9hh8cXedMXX09Gc/edit#gid=0
there are modules used @HLT which still need to be migrated and be multithread safe

this is the migration of the module PixelVertexProducer

[mtosi]

@VinInn @rovere @cerati

[cmsbuild]

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_4_X.

migration from EDProducer to stream::EDProducer (PixelVertexProducer)

It involves the following packages:

RecoPixelVertexing/PixelVertexFinding

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

-1
Tested at: 31012e3
I found an error when building:

>> Package Utilities/ReleaseScripts built
Entering library rule at src/Utilities/XrdAdaptor/plugins
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-11-26-0200/src/Utilities/XrdAdaptor/src/QualityMetric.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-11-26-0200/src/Utilities/XrdAdaptor/src/XrdFile.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-11-26-0200/src/Utilities/XrdAdaptor/src/XrdFile.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-11-26-0200/src/Utilities/XrdAdaptor/src/XrdFile.h:7:31: fatal error: XrdCl/XrdClFile.hh: No such file or directory
 # include "XrdCl/XrdClFile.hh"
                               ^
compilation terminated.
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-11-26-0200/src/Utilities/XrdAdaptor/src/XrdFile.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-11-26-0200/src/Utilities/XrdAdaptor/src/XrdFile.h:7:31: fatal error: XrdCl/XrdClFile.hh: No such file or directory


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6662/1210/summary.html

[mtosi]

I'm sorry, but I do not understand
I test the compilation before requesting the pull

what am I missing ?

[VinInn]

I suspect the problem is not related to this PR (smells xrootd stuff)

[slava77]

+1

for #6662 31012e3

tested in CMSSW_7_4_X_2014-11-27-0200 ( test area sign469, in combination with PRs 6658-6659-6662-6670-6671-6687)

checked with a short matrix: no diffs in reco, no diffs in 5.1 and 25.0 short matrix DQM outputs

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing).

[slava77]

@cmsbuild
are we waiting for tests, they should be rerun or bypassed

[cmsbuild]

+1
Tested at: 31012e3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6662/1371/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6662/1371/summary.html