Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration from EDFilter to stream::EDFilter (DetectorStateFilter) #6672

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Nov 27, 2014

as reported by @fwyzard
https://docs.google.com/spreadsheets/d/1D9khDvOl05WEbznsUPCusEbrHeep9hh8cXedMXX09Gc/edit#gid=0
there are modules used @HLT which still need to be migrated and be multithread safe

this is the migration of the module DetectorStateFilter

@mtosi
Copy link
Contributor Author

mtosi commented Nov 27, 2014

@rovere @VinInn @cerati

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_4_X.

migration from EDFilter to stream::EDFilter (DetectorStateFilter)

It involves the following packages:

DQM/TrackerCommon

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

DetectorStateFilter::DetectorStateFilter( const edm::ParameterSet & pset )
: verbose_ ( pset.getUntrackedParameter<bool> ( "DebugOn", false ) )
, detectorType_ ( pset.getUntrackedParameter<std::string>( "DetectorType", "sistrip") )
, dcsStatusLabel_ ( consumes<DcsStatusCollection>( pset.getUntrackedParameter<edm::InputTag>( "DcsStatusLabel", edm::InputTag("scalersRawToDigi")) ) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this is what was already there, but I find it strange that last two parameters are untracked. Perhaps this needs to be added to Jira as something that should be reviewed?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Dec 1, 2014

+1
@mtosi please notice chris' comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 1, 2014
…multithread_detState

migration from EDFilter to stream::EDFilter (DetectorStateFilter)
@cmsbuild cmsbuild merged commit 8e8e026 into cms-sw:CMSSW_7_4_X Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants