New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migration from EDFilter to stream::EDFilter (DetectorStateFilter) #6672
migration from EDFilter to stream::EDFilter (DetectorStateFilter) #6672
Conversation
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_4_X. migration from EDFilter to stream::EDFilter (DetectorStateFilter) It involves the following packages: DQM/TrackerCommon @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
DetectorStateFilter::DetectorStateFilter( const edm::ParameterSet & pset ) | ||
: verbose_ ( pset.getUntrackedParameter<bool> ( "DebugOn", false ) ) | ||
, detectorType_ ( pset.getUntrackedParameter<std::string>( "DetectorType", "sistrip") ) | ||
, dcsStatusLabel_ ( consumes<DcsStatusCollection>( pset.getUntrackedParameter<edm::InputTag>( "DcsStatusLabel", edm::InputTag("scalersRawToDigi")) ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this is what was already there, but I find it strange that last two parameters are untracked. Perhaps this needs to be added to Jira as something that should be reviewed?
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
…multithread_detState migration from EDFilter to stream::EDFilter (DetectorStateFilter)
as reported by @fwyzard
https://docs.google.com/spreadsheets/d/1D9khDvOl05WEbznsUPCusEbrHeep9hh8cXedMXX09Gc/edit#gid=0
there are modules used @HLT which still need to be migrated and be multithread safe
this is the migration of the module DetectorStateFilter