Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QIE8 preamp simulation #6676

Merged
merged 2 commits into from Dec 11, 2014
Merged

QIE8 preamp simulation #6676

merged 2 commits into from Dec 11, 2014

Conversation

cmsbuild
Copy link
Contributor

Initial implementation of the QIE8 HCAL preamp simulation.
More information is available from
https://indico.cern.ch/event/351640/contribution/2/material/slides/0.pdf

Automatically ported from CMSSW_7_3_X #6322

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_4_X.

QIE8 preamp simulation

It involves the following packages:

CalibCalorimetry/HcalAlgos
CondCore/HcalPlugins
CondFormats/DataRecord
CondFormats/HcalObjects
CondTools/Hcal

@apfeiffer1, @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor

+1
Latest commit marked as "Tests OK" in CMSSW_7_3_X

@apfeiffer1
Copy link
Contributor

+1
provided the comparison turns out OK

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Dec 9, 2014

@diguida
Copy link
Contributor

diguida commented Dec 11, 2014

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants