Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assure no DS collision LHE relvals #6692

Merged

Conversation

franzoni
Copy link

  • needs to go on top of Adding first LHE sequence to RelVal  #6626 (already rebased on top of CMSSW_7_4_X)
  • enforces that no LHE workflow can produce the same /GEN dataset
  • /GEN recycling command all point to the same /GEN dataset

Giovanni Franzoni added 2 commits November 28, 2014 20:15
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_7_4_X.

assure no DS collision LHE relvals

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@franzoni
Copy link
Author

+1
tests passed for all generator and extendedgen sets

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 29, 2014
…W_7_4_X

assure no DS collision LHE relvals
@cmsbuild cmsbuild merged commit a97dfe9 into cms-sw:CMSSW_7_4_X Nov 29, 2014
@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

Seems that these workflows are failing in the IBs - is that expected?
[and how does this work for someone without cvmfs - does one get a good error message from cmsDriver (cmsfs is not required for CMSSW in general)]

@franzoni
Copy link
Author

hello David,

the crashes for the 6 new relvals happen because of the input dataset recycle used by default in the IB: until when we'll be able to run the workflows for the first time, the input won't be found.
I could remove the input command (PR needed), forcing temporarily that the step1 is actually executed.

Concerning cvmfs : if we remove the non existing input dataset, cvmfs will become necessary for the workflow to function. It is my understanding that cvmfs is installed throughout our computing infrastructure, GEN workflows exploit that assumption.

If you know for a fact that cmvf is not available on the IB machines (though are you sure ? Alessandro actually helped me to install it on my machine : https://twiki.cern.ch/twiki/bin/viewauth/CMS/CmsIbCvmfs),
there's no way we can solve these crashes. Otherwise, I can place the suggested PR in time for the 2am IB.

Cheers,
g.

@franzoni
Copy link
Author

@bendavid @inugent

@bendavid
Copy link
Contributor

On the general policy: we will try to avoid the cvmfs dependency for most GEN-SIM workflows, but for LHE workflows it is unavoidable, since the use of "alternate pdf weights" implies a large set of pdfs are used by the workflows, and they cannot all be included directly in the release.

@bendavid
Copy link
Contributor

On the error message, this is tricky because it is not possible for cmsDriver or even the ExternalLHEProducer to definitively know a priori whether the particular workflow really requires cvmfs.

@franzoni
Copy link
Author

Hi Josh, the error message is simple to digest:

Pythia at the step2 is trying to open this file :

29-Nov-2014 15:13:20 CET Closed file root://eoscms//eos/cms/store/data/Run2012B/MinimumBias/RAW/v1/000/194/533/0C1BB1C7-ACA2-E111-A831-003048D3750A.root?svcClass=default

:-P

@bendavid
Copy link
Contributor

@franzoni, sorry I was referring to David's comment about the error message when cvmfs is missing.

@davidlange6
Copy link
Contributor

Regarding cvmfs- my question is not for the IB infrastructure but for users.

On Nov 29, 2014, at 7:13 PM, Giovanni Franzoni <notifications@github.commailto:notifications@github.com> wrote:

hello David,

the crashes for the 6 new relvals happen because of the input dataset recycle used by default in the IB: until when we'll be able to run the workflows for the first time, the input won't be found.
I could remove the input command (PR needed), forcing temporarily that the step1 is actually executed.

Concerning cvmfs : if we remove the non existing input dataset, cvmfs will become necessary for the workflow to function. It is my understanding that cvmfs is installed throughout our computing infrastructure, GEN workflows exploit that assumption.

If you know for a fact that cmvf is not available on the IB machines (though are you sure ? Alessandro actually helped me to install it on my machine : https://twiki.cern.ch/twiki/bin/viewauth/CMS/CmsIbCvmfs),
there's no way we can solve these crashes. Otherwise, I can place the suggested PR in time for the 2am IB.

Cheers,
g.


Reply to this email directly or view it on GitHubhttps://github.com//pull/6692#issuecomment-64962064.

@davidlange6
Copy link
Contributor

Hi Josh

Remind me how big these particular files are? (The ones used by relvals which I presume will now be essentially fixed)

On Nov 29, 2014, at 7:17 PM, Josh Bendavid <notifications@github.commailto:notifications@github.com> wrote:

On the general policy: we will try to avoid the cvmfs dependency for most GEN-SIM workflows, but for LHE workflows it is unavoidable, since the use of "alternate pdf weights" implies a large set of pdfs are used by the workflows, and they cannot all be included directly in the release.


Reply to this email directly or view it on GitHubhttps://github.com//pull/6692#issuecomment-64962172.

@ktf
Copy link
Contributor

ktf commented Dec 1, 2014

Well, also in the IB infrastructure, while CVMFS might be available on some machines, we do not guarantee (e.g. on mac / arm) it is actually there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants