Porting Castor DQM to 7_0_X #67

pedro-cipriano · 2013-07-09T10:24:50Z

Moving histogram booking to beginRun (required by changes in the framework)
Removing EventDisplay module (useless artefact not meant for DMQ)
Verbose levels defined (to improve the debugging process)
Removed the getbyType statements (they are now became obsolete)
Code cleaning and improved readeability

…om-CMSSW_7_0_0_pre0

ktf · 2013-07-09T19:38:30Z

@rovere @deguio can you look into this? Pedro, once again, can you use a meaningful title for the pull request please?

cmsbuild · 2013-07-11T16:55:39Z

The following categories have been rejected by @deguio: DQM

@cms-git-dqm

deguio · 2013-07-11T16:58:49Z

The code doesn't run because of the following exception [1]
Pedro, could you please solve the problem, test the code and submit it again?

here the documentation needed in order to run the tests:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMOffline

in particular Test # 1,7,8, & 11 failed.
(just ignore test5 for the moment)

thanks,
F.

[1]
----- Begin Fatal Exception 11-Jul-2013 18:49:27 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 165633 lumi: 346 event: 448872519
[1] Running path 'dqmoffline_step'
[2] Calling event method for module CastorMonitorModule/'castorOfflineMonitor'
Exception Message:
Principal::getByLabel: Found zero products matching all criteria
Looking for type: FEDRawDataCollection
Looking for module label: source
Looking for productInstanceName:

Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

pedro-cipriano · 2013-07-12T18:56:28Z

I changed the global tag and that error disappeared. I will run the tests and see how it behaves.

ktf · 2013-07-16T11:33:32Z

@pedro-cipriano any news on this?

pedro-cipriano · 2013-07-16T12:13:03Z

Dear Giulio,

The code was not designed to handle some of those tests and I dont know how to make it compatible. This incompatibility is present also in the old code. To solve this I will have to understand each test in detail (i think that the main problem is the lack of raw data).

Could you approve the code, as any of the changes proposed have anything to do with this problem?

Best regards, Pedro

ktf · 2013-07-16T12:31:31Z

That's a question for @deguio.

deguio · 2013-07-23T09:53:24Z

ciao @pedro-cipriano ,
I had a quick look and there are at least 2 things to be corrected.
I attach the patch here below.

please apply the changes to your code and update the pull request (#67)
I will test in detail once I receive the new notification.

thanks,
F.

diff --git a/DQM/CastorMonitor/interface/CastorMonitorModule.h b/DQM/CastorMonitor/interface/CastorMonitorModule.h
index 9f21d24..3de844c 100644
--- a/DQM/CastorMonitor/interface/CastorMonitorModule.h
+++ b/DQM/CastorMonitor/interface/CastorMonitorModule.h
@@ -53,7 +53,6 @@
#include "DQM/CastorMonitor/interface/CastorChannelQualityMonitor.h"
#include "DQM/CastorMonitor/interface/CastorLEDMonitor.h"
#include "DQM/CastorMonitor/interface/CastorPSMonitor.h"
-#include "DQM/CastorMonitor/interface/CastorEventDisplay.h"
#include "DQM/CastorMonitor/interface/CastorHIMonitor.h"
#include "DQM/CastorMonitor/interface/CastorDataIntegrityMonitor.h"
#include "DQM/CastorMonitor/interface/CastorTowerJetMonitor.h"
diff --git a/DQM/CastorMonitor/python/castor_dqm_sourceclient_offline_cfi.py b/DQM/CastorMonitor/python/castor_dqm_sourceclient_offline_cfi.py
index 4614e59..22ea4fd 100644
--- a/DQM/CastorMonitor/python/castor_dqm_sourceclient_offline_cfi.py
+++ b/DQM/CastorMonitor/python/castor_dqm_sourceclient_offline_cfi.py
@@ -16,7 +16,7 @@ castorOfflineMonitor = cms.EDAnalyzer("CastorMonitorModule",

                       # Define Labels
                        digiLabel            = cms.InputTag("castorDigis"),

                      rawLabel             = cms.InputTag("source"),

                      rawLabel             = cms.InputTag("rawDataCollector"),
                    unpackerReportLabel  = cms.InputTag("castorDigis"),
                    CastorRecHitLabel    = cms.InputTag("castorreco"),
                    CastorTowerLabel     = cms.InputTag("CastorTowerReco"),

pedro-cipriano · 2013-07-25T09:26:01Z

Dear deguio,

Thank you for help.

I changed the labels and I'm sending now the update.

Best Regards, Pedro

Pedro Miguel Ribeiro Cipriano
pedro.cipriano@desy.de, pedro.cipriano@ua.pt, pedro.miguel.ribeiro.cipriano@cern.ch
Scientific Assistant - PhD Student
CMS Group, DESY Hamburg, Germany
Forward Physics, CASTOR, Unfolding

-----Mensagem original-----
De: deguio [mailto:notifications@github.com]
Enviada: ter 23-07-2013 11:53
Para: cms-sw/cmssw
Cc: Cipriano, Pedro
Assunto: Re: [cmssw] Porting Castor DQM to 7_0_X (#67)

ciao,
I had a quick look and there are at least 2 things to be corrected.
I attach the patch here below.

please apply the changes to your code and update the pull request (#67)
I will test in detail once I receive the new notification.

thanks,
F.

diff --git a/DQM/CastorMonitor/interface/CastorMonitorModule.h b/DQM/CastorMonitor/interface/CastorMonitorModule.h
index 9f21d24..3de844c 100644
--- a/DQM/CastorMonitor/interface/CastorMonitorModule.h
+++ b/DQM/CastorMonitor/interface/CastorMonitorModule.h
@@ -53,7 +53,6 @@
#include "DQM/CastorMonitor/interface/CastorChannelQualityMonitor.h"
#include "DQM/CastorMonitor/interface/CastorLEDMonitor.h"
#include "DQM/CastorMonitor/interface/CastorPSMonitor.h"
-#include "DQM/CastorMonitor/interface/CastorEventDisplay.h"
#include "DQM/CastorMonitor/interface/CastorHIMonitor.h"
#include "DQM/CastorMonitor/interface/CastorDataIntegrityMonitor.h"
#include "DQM/CastorMonitor/interface/CastorTowerJetMonitor.h"
diff --git a/DQM/CastorMonitor/python/castor_dqm_sourceclient_offline_cfi.py b/DQM/CastorMonitor/python/castor_dqm_sourceclient_offline_cfi.py
index 4614e59..22ea4fd 100644
--- a/DQM/CastorMonitor/python/castor_dqm_sourceclient_offline_cfi.py
+++ b/DQM/CastorMonitor/python/castor_dqm_sourceclient_offline_cfi.py
@@ -16,7 +16,7 @@ castorOfflineMonitor = cms.EDAnalyzer("CastorMonitorModule",

                       # Define Labels
                        digiLabel            = cms.InputTag("castorDigis"),

                      rawLabel             = cms.InputTag("source"),

                      rawLabel             = cms.InputTag("rawDataCollector"),
                    unpackerReportLabel  = cms.InputTag("castorDigis"),
                    CastorRecHitLabel    = cms.InputTag("castorreco"),
                    CastorTowerLabel     = cms.InputTag("CastorTowerReco"),

Reply to this email directly or view it on GitHub:
#67 (comment)

deguio · 2013-07-25T12:57:29Z

@pedro-cipriano I am not sure I understand. I would suggest you to apply the patch I have pasted in my previous message. here the changes again:

in DQM/CastorMonitor/interface/CastorMonitorModule.h
remove
#include "DQM/CastorMonitor/interface/CastorEventDisplay.h"

in DQM/CastorMonitor/python/castor_dqm_sourceclient_offline_cfi.py
change
rawLabel = cms.InputTag("source"),
to
rawLabel = cms.InputTag("rawDataCollector")

please ask if something is not clear.
ciao and thanks,
F.

pedro-cipriano · 2013-07-25T14:22:25Z

@deguio: Sorry for the misunderstanding. It is now done. Thank you.

deguio · 2013-07-25T15:07:15Z

@pedro-cipriano the second change I was suggesting is still missing:

in DQM/CastorMonitor/python/castor_dqm_sourceclient_offline_cfi.py
change
rawLabel = cms.InputTag("source"),
to
rawLabel = cms.InputTag("rawDataCollector")

pedro-cipriano · 2013-07-25T22:21:04Z

Now I got it. I had never used this offline file, that is why I never changed it. But I will now.

nclopezo · 2013-07-31T09:31:55Z

Hi,

I tested took CMSSW_7_0_X_2013-07-30-1400, pulled these changes, ran the unit tests, and RelVals. All tests passed.

nclopezo · 2013-07-31T09:39:42Z

Hi @deguio

Could you sign this pull request if everything is ok?

Thanks

cmsbuild · 2013-07-31T12:50:57Z

The following categories have been signed by @deguio: DQM

@cms-git-dqm

Porting Castor DQM to 7_0_X

added yMin=0 to the url of the graphs

Replace PR cms-sw#67 on 74X branch

Cmg tools from cmssw 7 4 3

Add jet id variables for PF jets

Triggercell dataformat (pre9 backport)

probably this patch will make submit work

Temporary customize to the unit tests that fail due to old input samples (2nd bunch)

Update to CMSSW 9_4_0

Update setup instruction for 10_3_X and point to old releases

* Update Settings.h * Update TrackletCalculatorDisplaced.cc

…r-dev Sync deregionizer with correlator-common repo

pedro-cipriano added 7 commits July 8, 2013 18:49

histogram booking moved to the bigRun routines

bf4174b

moving histogram booking to beginRun

b57793c

moving the histogram booking to beginRun

23b517f

removing the module EventDisplay because it is obsolete

1d108fc

Merge branch 'CMSSW_7_0_X' of https://github.com/cms-sw/cmssw into fr…

4972af1

…om-CMSSW_7_0_0_pre0

Merge branch 'CMSSW_7_0_X' of https://github.com/cms-sw/cmssw into fr…

bd7b63c

…om-CMSSW_7_0_0_pre0

moving histograms to beginRun

792e730

update conf tag

915efbb

remove event display from the monitor interface

36c79c5

changed raw label in offline configuration

0d32f1b

nclopezo added a commit that referenced this pull request Jul 31, 2013

Merge pull request #67 from pedro-cipriano/from-CMSSW_7_0_0_pre0

9518fa2

Porting Castor DQM to 7_0_X

nclopezo merged commit 9518fa2 into cms-sw:CMSSW_7_0_X Jul 31, 2013

nclopezo added a commit to nclopezo/cmssw that referenced this pull request Nov 21, 2014

Merge pull request cms-sw#67 from nclopezo/add-yMin

2102655

added yMin=0 to the url of the graphs

arizzi added a commit to arizzi/cmssw that referenced this pull request Jun 23, 2015

Merge pull request cms-sw#75 from jpata/tth-vhbb-743

1d779cc

Replace PR cms-sw#67 on 74X branch

gpetruc pushed a commit to gpetruc/cmssw that referenced this pull request Aug 13, 2015

Merge pull request cms-sw#67 from MT2Analysis/CMGTools-from-CMSSW_7_4_3

b88722f

Cmg tools from cmssw 7 4 3

mandrenguyen pushed a commit to mandrenguyen/cmssw that referenced this pull request Mar 14, 2016

Merge pull request cms-sw#67 from mverwe/addJetIDVarsMerge

fbfcdab

Add jet id variables for PF jets

civanch mentioned this pull request Jun 17, 2016

Add phase2 Inner Tracker (IT) pixel cluster to cmssw 81X from new IB #14885

Merged

jbsauvan added a commit to jbsauvan/cmssw that referenced this pull request Nov 3, 2016

Merge pull request cms-sw#67 from jbsauvan/triggercell-dataformat-pre9

9e9d219

Triggercell dataformat (pre9 backport)

mariadalfonso pushed a commit to mariadalfonso/cmssw that referenced this pull request May 6, 2017

Merge pull request cms-sw#67 from amarini/topic_80X

bea47d4

probably this patch will make submit work

cmsbuild pushed a commit that referenced this pull request Nov 3, 2017

Merge pull request #67 from mbluj/CMSSW_9_4_X_tauMVAIso2017v1

07ebdd3

Temporary customize to the unit tests that fail due to old input samples (2nd bunch)

vasile-ghete pushed a commit to vasile-ghete/cmssw that referenced this pull request Nov 13, 2017

Merge pull request cms-sw#67 from peruzzim/cmssw940

34e6033

Update to CMSSW 9_4_0

felicepantaleo pushed a commit to felicepantaleo/cmssw that referenced this pull request Mar 28, 2019

Merge pull request cms-sw#67 from clelange/10_3_X_setup

6a4d49c

Update setup instruction for 10_3_X and point to old releases

cmsbuild pushed a commit that referenced this pull request Feb 11, 2021

Gabhijith patch 1 (#67)

987904d

* Update Settings.h * Update TrackletCalculatorDisplaced.cc

franzoni pushed a commit to franzoni/cmssw that referenced this pull request May 3, 2021

Add storeGunParticles flag to NTUP template. (cms-sw#67)

48fc24f

gpetruc added a commit to gpetruc/cmssw that referenced this pull request Aug 4, 2021

Merge pull request cms-sw#67 from p2l1pfp/VourMa-deregionizer-emulato…

686d277

…r-dev Sync deregionizer with correlator-common repo

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Porting Castor DQM to 7_0_X #67

Porting Castor DQM to 7_0_X #67

pedro-cipriano commented Jul 9, 2013

ktf commented Jul 9, 2013

cmsbuild commented Jul 11, 2013

deguio commented Jul 11, 2013

pedro-cipriano commented Jul 12, 2013

ktf commented Jul 16, 2013

pedro-cipriano commented Jul 16, 2013

ktf commented Jul 16, 2013

deguio commented Jul 23, 2013

pedro-cipriano commented Jul 25, 2013

deguio commented Jul 25, 2013

pedro-cipriano commented Jul 25, 2013

deguio commented Jul 25, 2013

pedro-cipriano commented Jul 25, 2013

nclopezo commented Jul 31, 2013

nclopezo commented Jul 31, 2013

cmsbuild commented Jul 31, 2013

Porting Castor DQM to 7_0_X #67

Porting Castor DQM to 7_0_X #67

Conversation

pedro-cipriano commented Jul 9, 2013

ktf commented Jul 9, 2013

cmsbuild commented Jul 11, 2013

deguio commented Jul 11, 2013

pedro-cipriano commented Jul 12, 2013

ktf commented Jul 16, 2013

pedro-cipriano commented Jul 16, 2013

ktf commented Jul 16, 2013

deguio commented Jul 23, 2013

pedro-cipriano commented Jul 25, 2013

deguio commented Jul 25, 2013

pedro-cipriano commented Jul 25, 2013

deguio commented Jul 25, 2013

pedro-cipriano commented Jul 25, 2013

nclopezo commented Jul 31, 2013

nclopezo commented Jul 31, 2013

cmsbuild commented Jul 31, 2013