Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting L1 trigger printout and multithreading #6705

Merged
merged 1 commit into from Dec 2, 2014

Conversation

avetisya
Copy link
Contributor

@avetisya avetisya commented Dec 1, 2014

This is an exact copy of PR #6704 to keep 73X up to date. The description of the original PR is below:

This PR modifies the output format of the L1 JSON by making sure that unassigned trigger bits (i.e. those without names) are included in the JSON file. This is necessary because the database expects vectors of a fixed size (even if the information in some entries is meaningless) whereas with the old approach the size could vary.

There is also a very small fix to the multithreading. A more thorough revision of the latter will be done after the mid-week global run.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2014

A new Pull Request was created by @avetisya for CMSSW_7_3_X.

Correcting L1 trigger printout and multithreading

It involves the following packages:

HLTrigger/JSONMonitoring

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants