Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important BUG FIX in parameter assignment of millepede-based tracker alignment #6716

Conversation

mschrode
Copy link

@mschrode mschrode commented Dec 1, 2014

The bug corrupts the IOV-dependent alignment in releases compiled with
slc6_amd64_gcc472 and later. It is caused by using a dangling reference to
an edm::EventID object to determine the run number. At least with the gcc
versions in SLC6, this results in an incorrect determination of the current
IOV. Details are given in this presentation at the tracker-alignment meeting:

https://indico.cern.ch/event/342234/session/0/contribution/8/0/material/slides/0.pdf

The implementation is the outcome of a discussion of #6515 .

This PR supersedes #6518 .

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2014

A new Pull Request was created by @mschrode (Matthias Schroeder) for CMSSW_5_3_X.

Important BUG FIX in parameter assignment of millepede-based tracker alignment

It involves the following packages:

Alignment/CommonAlignmentAlgorithm
Alignment/HIPAlignmentAlgorithm
Alignment/KalmanAlignmentAlgorithm
Alignment/MillePedeAlignmentAlgorithm
Alignment/MuonAlignmentAlgorithms

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @battibass, @abbiendi, @tlampen, @mmusich, @trocino this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@frmeier
Copy link
Contributor

frmeier commented Dec 2, 2014

@smuzaffar @cmsbuild : Would you mind proceeding with the tests? This PR is needed to create results that need to be approved. We should not use privately patched areas for such things. Kind regards, TkAlignment conveners.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2014

@diguida
Copy link
Contributor

diguida commented Mar 24, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar, @ktf

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 25, 2015
…Members-53X

Important BUG FIX in parameter assignment of millepede-based tracker alignment
@cmsbuild cmsbuild merged commit 1bd3b47 into cms-sw:CMSSW_5_3_X Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants