Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed lumi producer from HI reco #6738

Merged
merged 3 commits into from Dec 24, 2014

Conversation

mandrenguyen
Copy link
Contributor

The lumi producer appears to have been removed from the pp reconstruction since 42X, but this change was never propagated to HI reco.
Now it appears to be causing a crash, at least at one site, and we were advised on the luminosity hypernews to remove it:
https://hypernews.cern.ch/HyperNews/CMS/get/luminosity/440/1.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2014

A new Pull Request was created by @mandrenguyen for CMSSW_7_4_X.

removed lumi producer from HI reco

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @nclopezo, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

@davidlange6
Copy link
Contributor

@slava77 , @StoyanStoynev - any issues you see with this?

@slava77
Copy link
Contributor

slava77 commented Dec 3, 2014

David,

This PR makes things look more like pp reco: lumiProducer is running only in prompt.
On the other hand, from earlier discussions with lumi, I got an impression that we may be getting it back for rerecos as well.

There is one piece missing in this change:
Configuration/DataProcessing/python/RecoTLR.py should be updated in the customisePromptHI to add the lumiProducer here.

@davidlange6
Copy link
Contributor

@mandrenguyen - could you take care of this request from @slava77?

@mandrenguyen
Copy link
Contributor Author

@davidlange6
I somehow missed that this was an action item for me.
I'm at a workshop, but will take care of it Monday.

Added back lumiProducer to prompt reco customization upon Slava's request
Need to import lumiProducer even though not used by default, as it can be called from the prompt reco customization (same is done for pp)
@mandrenguyen
Copy link
Contributor Author

@davidlange6 @slava77
This was updated a couple of days ago.
I was expecting this to trigger cmsbuild, but I guess not.

@cmsbuild
Copy link
Contributor

Pull request #6738 was updated. @cmsbuild, @franzoni, @nclopezo, @davidlange6 can you please check and sign again.

@nclopezo
Copy link
Contributor

test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants