Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondFormat storing configuration parameters for the new DYT #6755

Merged
merged 5 commits into from Dec 11, 2014

Conversation

battibass
Copy link

This PR includes a CondFormat that is aimed at storing vectors floats (representing the parameters of a parametrised function) to be used by a new version of the DYT TeV muon refit presently under development.
A single functional form is expected to be used all around the muon spectrometer but it's parameters might be configured with a granularity up to the single muon chamber (to be clarified).

This PR is mostly related to adding things to the AlCa domain, the only chane in RECO is the addition of an analyzer that allows to populate the CondFormat itself and write it to sqlite.
The latter is not affecting any RECO sequence, simply the code was added under "RecoMuon/GlobalTrackingTools/test/" as there is where similar modules to configure DYT are at present.

of the  DYT TeV refit code presently under development toghether
with the trivial code to populate it from txt.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

A new Pull Request was created by @battibass (Carlo Battilana) for CMSSW_7_4_X.

CondFormat storing configuration parameters for the new DYT

It involves the following packages:

CondFormats/DataRecord
CondFormats/RecoMuonObjects
RecoMuon/GlobalTrackingTools

@apfeiffer1, @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @StoyanStoynev, @slava77, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@abbiendi, @bellan, @trocino, @amagitte, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.


if (iParam >= paramSize())
{
std::cout << "[DYTParamObject::parameter] "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No couts, use MessageLogger.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, sorry I planned to change couts to MessageLogger before sending the PR but I forgot.

@Dr15Jones
Copy link
Contributor

class versions of 0 and 1 have special meaning for ROOT therefore 2 is the first user allowed value.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

Pull request #6755 was updated. @apfeiffer1, @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @StoyanStoynev, @slava77, @ggovi, @mmusich can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Dec 3, 2014

@battibass @diguida @rcastello
Why are the DB read/writers not in CondTools?
What's the AlcaDB policy?

In this particular case the RecoMuon/GlobalTrackingTools/test/DYTParamsWriter.cc just reads a non-edm input file and writes a payload.
This doesn't really belong in reco, IMO.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2014

@diguida
Copy link
Contributor

diguida commented Dec 11, 2014

+1
Thanks @battibass for reminding this to me

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 11, 2014
CondFormat storing configuration parameters for the new DYT
@cmsbuild cmsbuild merged commit b12b661 into cms-sw:CMSSW_7_4_X Dec 11, 2014
@battibass battibass deleted the dytParamsCondFormat74X branch October 12, 2016 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants