Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaloTowers and Hcal geometry test #677

Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Aug 30, 2013

  • Compare eta of centres and corners between CaloTower and Hcal cell with the same iEta, iPhi, and Z side for all depths
  • Remove unused code

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_0_X.

CaloTowers and Hcal geometry test

It involves the following packages:

Geometry/HcalTowerAlgo

@Dr15Jones, @ianna, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor

nclopezo commented Sep 3, 2013

Hi,

I ran the usual tests for this pull request on top of CMSSW_7_0_X_2013-09-03-0200, all tests passed.

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/368/console

you can see the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/368/

@ianna
Copy link
Contributor Author

ianna commented Sep 4, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

nclopezo added a commit that referenced this pull request Sep 4, 2013
@nclopezo nclopezo merged commit 182a6ff into cms-sw:CMSSW_7_0_X Sep 4, 2013
@ianna ianna deleted the calotowers-and-hcal-geometry-test branch October 26, 2015 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants