Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix electron GSF sequence for fastsim HLT (72X) #6772

Merged

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Dec 3, 2014

Fix for the gsfElectron sequence in FastSim HLT, that showed up since the migration to gsf tracking for electrons.

@matteosan1 @VinInn @beaudett

@lveldere: I let you push this one for the next 72X release for next week's MWGR9 if you think so. (This is not needed for any MWGR, of course, but it can be a good opportunity for having it in).

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

A new Pull Request was created by @perrotta for CMSSW_7_2_X.

Fix electron GSF sequence for fastsim HLT (72X)

It involves the following packages:

FastSimulation/EgammaElectronAlgos
FastSimulation/HighLevelTrigger
HLTrigger/Configuration

@perrotta, @cmsbuild, @civanch, @nclopezo, @lveldere, @mdhildreth, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@geoff-smith, @jalimena this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

+1

This is a bug fix, so should go in!

@lveldere
Copy link
Contributor

lveldere commented Dec 4, 2014

+1

Thanks Andrea!
I second Martin's statement.

@davidlange6
Copy link
Contributor

is there some reason you expect that it won't go in after its tested and signed? [not that I know why one should be worrying about fastsim in 72x at this point]

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants