New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeSlewSim bugfix #6788
TimeSlewSim bugfix #6788
Conversation
A new Pull Request was created by @abdoulline for CMSSW_7_3_X. TimeSlewSim bugfix It involves the following packages: SimCalorimetry/HcalSimAlgos @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
Fixes the bug introduced in HCAL digitization in 730pre2, which affects high-energy part of the spectrum (rechits with > 1 TeV in HB/HE, reducing their energy by factor 3-4). Not visible in regular QCD and TTbar samples, only noticeable in QCD_Pt_3000-3500 RelVal.
Private very-high-energy single-pion gun event-by-event tests and re-digi/re-reco of QCD_Pt_3000-3500 RelVal:
http://hep.baylor.edu/cmshcal/Validation/MC/730pre3_MCRUN2_73_V5-v1_TimeSlewFix_vs_730pre3_MCRUN2_73_V5-v1_noChange_RelVal/HighPtQCD/RecHits/RecHits_energy_HB.gif
show that the bug is fixed.