Make unit test fail immediately if one of the cmsRun commands fail #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the one hand -e would immediately stop the script and takes less code (2 characters), which is good. On the other hand, the way it is done prints out helpful info into the log that says exactly what command and configuration failed. I was also copying a pattern in these test shell scripts which has been around longer than I have which I have copied many times before. I do not know who started it. |
|
Ok... I guess we should clean up all our scripts to always run with -e ... Merging this for now. |
ktf
added a commit
that referenced
this pull request
Jul 9, 2013
Make unit test fail immediately if one of the cmsRun commands fail
nclopezo
added a commit
to nclopezo/cmssw
that referenced
this pull request
Nov 21, 2014
Identifies the prs that went into the branch from a merge commit
gpetruc
pushed a commit
to gpetruc/cmssw
that referenced
this pull request
Nov 23, 2014
gdimperi
pushed a commit
to gdimperi/cmssw
that referenced
this pull request
Jun 21, 2015
Check that the decay postfix is conforming
gpetruc
pushed a commit
to gpetruc/cmssw
that referenced
this pull request
Aug 13, 2015
Updated to cmg-central; some conflicts resolved
arizzi
pushed a commit
to arizzi/cmssw
that referenced
this pull request
Feb 1, 2016
Thanks Giovanni and all
tstreble
pushed a commit
to tstreble/cmssw
that referenced
this pull request
Nov 20, 2017
Read basic cut-based muon ID from standard selectors
cmsbuild
pushed a commit
that referenced
this pull request
Nov 23, 2017
Customize to the unit tests that fail due to old input samples
makortel
pushed a commit
to makortel/cmssw
that referenced
this pull request
Jun 5, 2018
felicepantaleo
pushed a commit
to felicepantaleo/cmssw
that referenced
this pull request
Mar 28, 2019
Update ntuplizer and sample to the latest pre-release
cmsbuild
pushed a commit
that referenced
this pull request
Feb 11, 2021
Co-authored-by: Anders <aryd@cern.ch>
gpetruc
added a commit
to gpetruc/cmssw
that referenced
this pull request
Aug 6, 2021
Update to l1t-phase2-v3.3.39 tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.