Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subjets to softdrop #6817

Merged
merged 10 commits into from Dec 10, 2014
Merged

Add subjets to softdrop #6817

merged 10 commits into from Dec 10, 2014

Conversation

ahinzmann
Copy link
Contributor

Followup of #6654.
In order to fully replace pruning, enable subjet calculation for softdrop algorithm.

Adaption of the jet collections and jet pT thresholds will come in a separate request after discussion.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2014

A new Pull Request was created by @ahinzmann for CMSSW_7_4_X.

Add subjets to softdrop

It involves the following packages:

DQM/Physics
RecoJets/Configuration
RecoJets/JetProducers

@nclopezo, @deguio, @danduggan, @cmsbuild, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @yslai, @TaiSakuma, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@deguio
Copy link
Contributor

deguio commented Dec 8, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2014

-1
Tested at: a1b34ee
When I ran the RelVals I found an error in the following worklfows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
----- Begin Fatal Exception 09-Dec-2014 10:33:01 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named SingleElectronE120EHCAL_cfi_GEN_SIM_DIGI_DIGI2RAW_RAW2DIGI_L1Reco_RECO_EI.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL
----- End Fatal Exception -------------------------------------------------

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 09-Dec-2014 10:33:08 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_Tauola_8TeV_cfi_GEN_SIM_RECO_EI_HLT_VALIDATION.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 09-Dec-2014 10:33:26 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_RAW2DIGI_L1Reco_RECO_EI_DQM.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log
----- Begin Fatal Exception 09-Dec-2014 10:33:28 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_RAW2DIGI_L1Reco_RECO_EI_ALCAPRODUCER_DQM_ENDJOB.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 09-Dec-2014 10:33:28 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_RAW2DIGI_L1Reco_RECO_EI_ALCAPRODUCER_DQM_ENDJOB.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT
----- End Fatal Exception -------------------------------------------------

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS/step2_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS.log
----- Begin Fatal Exception 09-Dec-2014 10:33:37 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named SingleMuPt10_cfi_GEN_SIM_RECO_EI_HLT_VALIDATION.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/wpDiscriminationByIsolationMVA3_oldDMwoLT.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log
----- Begin Fatal Exception 09-Dec-2014 10:36:22 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_EI_ALCA_DQM.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 09-Dec-2014 10:37:36 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_EI_VALIDATION_DQM.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 09-Dec-2014 10:46:45 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_EI_VALIDATION_DQM.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 09-Dec-2014 10:48:30 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_EI_VALIDATION_DQM.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 09-Dec-2014 10:59:20 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_EI_VALIDATION_DQM_PU.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6817/1517/summary.html

@ahinzmann
Copy link
Contributor Author

@cmsbuild: Could you test again?
This error is not related to this pull request.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2014

@StoyanStoynev
Copy link
Contributor

I tested 5c83701 on top of CMSSW_7_4_X_2014-12-05-1400.
I ran some of the extended matrix tests (wf 202 in particular). No differences except the ones to mention below. They can also be seen in jenkins.

RECO/AOD content, wf 202: one branch disappears, two new appear (Bytes/Event; slight increase)
gone: recoPFJets_ak8PFJetsCHSSoftDrop__RECO. 2435.18
new: recoPFJets_ak8PFJetsCHSSoftDrop_SubJets_RECO. 3145.86
new: recoBasicJets_ak8PFJetsCHSSoftDrop__RECO. 333.135

As can be seen in jenkins (last plots):
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_7_4_X_2014-12-08-0200+6817/5288/alternative-comparisons/4.53-result.ps.gz

New subjets info appears but PFJetID info disappears. @ahinzmann , @deguio do we need renaming in DQM to reflect the changes? Or is the change what you expect to have?

@ahinzmann
Copy link
Contributor Author

I confirm that this is exactly what was intended:
gone: recoPFJets_ak8PFJetsCHSSoftDrop__RECO. 2435.18
new: recoPFJets_ak8PFJetsCHSSoftDrop_SubJets_RECO. 3145.86
new: recoBasicJets_ak8PFJetsCHSSoftDrop__RECO. 333.135

About PFJetID info: The concept is the same as for pruning and subjets. The information is still available by looking at the PFJetID info of the subjets which are daughters of the BasicJet. However, PFJetID in analysis is usually applied to the plain ak8PFJetsCHS collection and the corresponding softdrop is only used for W-tagging.

About DQM: Softdrop is monitored in the B2GDQM and this is already modified accordingly.

@StoyanStoynev
Copy link
Contributor

+1
For 5c83701.
Based on the above summary and discussion.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants