fix beampixel application and Vx3DHLTAnalyzer class [online only] #6820
Conversation
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
| #include <Math/Minimizer.h> | ||
| #include <Math/Factory.h> | ||
| #include <Math/Functor.h> | ||
|
|
||
|
|
||
| using namespace std; | ||
| using namespace reco; | ||
| using namespace edm; |
There was a problem hiding this comment.
i'm a bit lost with the removal of this using namespace and at the same time the removal of edm;: in a number of places. How does this work?
There was a problem hiding this comment.
these are simply moved in the header
There was a problem hiding this comment.
ah yes- since its a plugin header its ok.
|
-1 runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS/step2_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS.log you can see the results of the tests here: |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
DAS error |
|
+1 |
cmsbuild
added
comparison-pending
and removed
comparison-pending
dqm-approved
fully-signed
orp-pending
tests-rejected
labels
fix beampixel application and Vx3DHLTAnalyzer class [online only]
No description provided.