fixed chi2 constraint on pedestal and time

[violatingcp]

fixed chi2 constraint on pedestal and time

[cmsbuild]

A new Pull Request was created by @violatingcp (Philip Harris) for CMSSW_7_3_X.

fixed chi2 constraint on pedestal and time

It involves the following packages:

RecoLocalCalo/HcalRecAlgos

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[StoyanStoynev]

@cmsbuild please test

[davidlange6]

merging - @StoyanStoynev , @slava77 - please test in parallel with the release build.

[StoyanStoynev]

I am testing it

[cmsbuild]

+1
Tested at: 83e5947
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6855/1567/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6855/1567/summary.html

[StoyanStoynev]

I tested on top of CMSSW_7_3_X_2014-12-09-0200.

Timing in wf 202 based on DQM :
hbheprereco 110.107 ms/ev -> 88.5865 ms/ev
There is an overall 10% difference for most of the modules so this is consistent with some 10% improvement (I suppose the main point is that the new code is not slower).

I made tests with wf 202, 25202, 38 (flat QCD) and 1313 (high pt QCD).
The main difference with the base IB is in HCAL timing estimates (wf 202 below):

The hit resolution is the same:

Although differences are seen in virtually all objects they are mostly statistically insignificant (or changing shapes only mildly):

Here is a plot from the high pt jets (~ same features in all tested wf's):

[StoyanStoynev]

Red above is this PR.