Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of Cintex in ROOT6 macros #6870

Merged
merged 1 commit into from Dec 11, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Dec 10, 2014

Cintex does not exist in ROOT6. This pull request removes the loading of libCintex.so and the enabling of Cintex from ROOT macros in the ROOT6 IB, since libCintex.so does not exist in ROOT6. The use of Cintex had previously been removed from other C++ code, but not from ROOT macros.
Please merge this request as soon as convenient.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X.

Remove use of Cintex in ROOT6 macros

It involves the following packages:

CommonTools/ParticleFlow
DataFormats/ParticleFlowReco
FastSimulation/MaterialEffects
PhysicsTools/Heppy
PhysicsTools/MVAComputer
PhysicsTools/MVATrainer
RecoMuon/MuonIdentification
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFClusterTools
RecoTauTag/TauTagTools
RecoTracker/TrackProducer
TrackingTools/TrackAssociator
Validation/EcalHits
Validation/GlobalDigis
Validation/GlobalHits
Validation/GlobalRecHits
Validation/MuonIdentification
Validation/RecoParticleFlow
Validation/TrackerHits

@civanch, @nclopezo, @StoyanStoynev, @lveldere, @danduggan, @mdhildreth, @monttj, @cmsbuild, @deguio, @slava77, @vadler can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @abbiendi, @argiro, @threus, @venturia, @mmarionncern, @battibass, @makortel, @acaudron, @lgray, @ferencek, @cerati, @trocino, @rociovilar, @jpavel, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @dgulhan, @imarches, @appeltel, @gpetruc, @matt-komm, @pvmulder, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@wmtan
Copy link
Contributor Author

wmtan commented Dec 11, 2014

ping

@lveldere
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants