Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix to compute ES cluster shapes #6919

Merged
merged 1 commit into from
Dec 17, 2014

Conversation

matteosan1
Copy link
Contributor

Bug fix to EcalClusterTools to compute Preshower cluster shapes. Same as #6917 but for 74X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_4_X.

bug fix to compute ES cluster shapes

It involves the following packages:

RecoEcal/EgammaCoreTools

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @argiro, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
For 71297a8.
I tested it on top of CMSSW_7_4_X_2014-12-14-0200. Short and extended matrix tests (including electron/photon wf) show no diffs. There are known false positives that can be seen in jenkins as well (EgOfflineHLT, Castor variables; also wf 25 is "dirty" - in past it was related to random seeds in simulation).
Related to #6917 and #6918.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 17, 2014
@cmsbuild cmsbuild merged commit 32f2b96 into cms-sw:CMSSW_7_4_X Dec 17, 2014
@matteosan1 matteosan1 deleted the topic_FixESClusterShapes74X branch May 28, 2015 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants