Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved G4 EM parameter definition from SetCuts() to ConstructProcess() #6921

Merged
merged 8 commits into from Dec 16, 2014

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Dec 15, 2014

  1. This move is needed for MT mode, no effect on sequential.
  2. Added option to enable GFlash for hadronic showers - needed for validation of FastSim.
  3. Fixed compilation problems seen when compile versus recent Geant4 release 10.1.
  4. Removed obsolete headers.

All this modifications do not affect production runs

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_4_X.

Moved G4 EM parameter definition from SetCuts() to ConstructProcess()

It involves the following packages:

SimG4Core/Application
SimG4Core/Physics

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #6921 was updated. @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please check and sign again.

@civanch
Copy link
Contributor Author

civanch commented Dec 16, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 16, 2014
Moved G4 EM parameter definition from SetCuts() to ConstructProcess()
@cmsbuild cmsbuild merged commit 28641dc into cms-sw:CMSSW_7_4_X Dec 16, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants