Fix checksums in framework #6961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for later re-enabling edmCheckClassVersion in the ROOT6 branch, this pull request corrects the checksums for classes in the framework.
One minor complication is that the inheritance of EDProductGetter on boost::noncopyable caused a problem, and is being replaced by the C++11 mechanism for disabling copy constructing and assignment.
A second complication is that many months ago I attempted to do this by hand for DataFormatsProvenance. That change is being backed out and the specification file of DataFormats/Provenance is being resynched with the ROOT5 branch before updating for ROOT6.
Please merge this request as soon as convenient.