Upgraded a bunch of modules in DQM/DataScouting

[vanbesien]

The mission was to upgrade one module: DQM/DataScouting/interface/ScoutingAnalyzerBase.

As always it turned out to be a bit more than that, since this was just a common base class to:
AlphaTVarAnalyzer
DiJetVarAnalyzer
RazorVarAnalyzer
ScoutingTestAnalyzer

There were no big anomalies in this, except for ScoutingTestAnalyzer, which seems to be a test class and also tries to book histograms in the endRun method, which is not really allowed anymore.
Since this is only a test class, and the historgrams are never filled not referenced later, I removed this.
Up to the maintainers/users of DataScouting to shout if they disagree.

[cmsbuild]

A new Pull Request was created by @vanbesien (Broen van Besien) for CMSSW_7_4_X.

Upgraded a bunch of modules in DQM/DataScouting

It involves the following packages:

DQM/DataScouting

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[ghost]

please test

[deguio]

+1
provided it passes the tests.
thanks @vanbesien
F.

[davidlange6]

Yes - it seems the tests are using 73x rather than 74x, which is the target of the pull request.

@ktf??

On Dec 29, 2014, at 2:11 PM, Broen van Besien <notifications@github.commailto:notifications@github.com> wrote:

Still the same error:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-12-17-1400/src/Utilities/XrdAdaptor/src/XrdFile.h:7:31: fatal error: XrdCl/XrdClFile.hh: No such file or directory

include "XrdCl/XrdClFile.hh"

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/6973#issuecomment-68256062.

[ktf]

please test

[vanbesien]

Unable to reproduce this.
After creating a fresh environment and merging this pr's topic branch, runTheMatrix.py -l 50101.0 runs just fine.

Comparing the logs, I can see that:

in the WORKING version (local):

• Initiating request to open file root://eoscms//blahblahblah
  
  Data is served from cern.ch instead of original site eoscms
• Successfully opened file root://eoscms//blahblahblah

in the FAILING version (Jenkins):

• Initiating request to open file root://eoscms//blahblahblah
  
  Data is served from cern.ch instead of original site eoscms
• Fallback request to file root://xrootd-cms.infn.it//blahblahblah
  
  Data is served from cern.ch instead of original site infn.it
  
  An exception of category 'FallbackFileOpenError' occurred while...

[vanbesien]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 6461587
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6973/1764/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6973/1764/summary.html