Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored functionality to print geometry and weights #6975

Merged
merged 1 commit into from Dec 18, 2014

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Dec 18, 2014

Due to migration to the thread safe randon engine geometry printing unit test did not work. These modifications restore these unit tests functionality.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_4_X.

Restored functionality to print geometry and weights

It involves the following packages:

SimG4Core/PrintGeomInfo

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@civanch
Copy link
Contributor Author

civanch commented Dec 18, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 18, 2014
Restored functionality to print geometry and weights
@cmsbuild cmsbuild merged commit 7408da9 into cms-sw:CMSSW_7_4_X Dec 18, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants