Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape all characters not allowed in XML tag names #6987

Merged
merged 1 commit into from Dec 19, 2014

Conversation

apfeiffer1
Copy link
Contributor

escape all characters not allowed in XML tag names when creating the name-value-pairs for boost.

Allowed characters for tag names are upper and lower case characters, numbers and ".", ":", "-", and "_".
Now all other characters are mapped to "-" when creating the "name" part of the name-value-pair in the generated code. With this fix, templated class names can be written out into xml format (with the "conddb --dump" command).

Tested with the short matrix.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_4_X.

escape all characters not allowed in XML tag names

It involves the following packages:

CondFormats/Serialization

@ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@apfeiffer1
Copy link
Contributor Author

+1
provided Jenkins agrees.

On Fri, Dec 19, 2014 at 5:25 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @apfeiffer1
https://github.com/apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_4_X.

escape all characters not allowed in XML tag names

It involves the following packages:

CondFormats/Serialization

@ggovi https://github.com/ggovi, @cmsbuild https://github.com/cmsbuild,
@apfeiffer1 https://github.com/apfeiffer1, @nclopezo
https://github.com/nclopezo can you please review it and eventually
sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.


Reply to this email directly or view it on GitHub
#6987 (comment).

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 19, 2014
escape all characters not allowed in XML tag names
@cmsbuild cmsbuild merged commit cdd1530 into cms-sw:CMSSW_7_4_X Dec 19, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants