Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlCa cleanups -- Interpolation log errors only once per channel. #699

Merged
merged 1 commit into from Oct 6, 2013

Conversation

argiro
Copy link
Contributor

@argiro argiro commented Sep 3, 2013

With certain GT, the error stream was flooded by errors due to laser corrections interpolation. With this fix, errors are logged at most once per channel. Replaces #259

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2013

A new Pull Request was created by @argiro for CMSSW_7_0_X.

log interpolation errors only once per channel, thread safe. Replaces #259

It involves the following packages:

CalibCalorimetry/EcalLaserCorrection

@demattia, @rcastello can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor

nclopezo commented Sep 3, 2013

Hi

I ran the tests on top of CMSSW_7_0_X_2013-09-02-0200, all tests passed

The logs are here:
https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/373/consoleFull

and the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/373/

@Dr15Jones
Copy link
Contributor

@argiro I want to say 'thank you' to Stefano for being patient enough to get a thread safe version implemented.

@argiro
Copy link
Contributor Author

argiro commented Sep 3, 2013

@Dr15Jones oh no, please, thank you for the opportunity to explore tbb, C++11 and this (complicated) new world !

@ktf
Copy link
Contributor

ktf commented Sep 12, 2013

@demattia @rcastello can you check this?

@ktf
Copy link
Contributor

ktf commented Sep 25, 2013

ping?

@rcastello
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Oct 6, 2013
AlCa cleanups -- Interpolation log errors only once per channel.
@ktf ktf merged commit 7ea695f into cms-sw:CMSSW_7_0_X Oct 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants