No longer use TrackAssociatorByChi2 to get dca to beam spot

[Dr15Jones]

Moved the calculation of tracking parameters at the closest approach
to the beam spot to a stand alone function. This allows TrackAssociatorByChi2
and the VertexFitterResult to share the code with the minimum amount of
coupling.

This is the first step to fixing the consumes problem with TrackAssociators.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

No longer use TrackAssociatorByChi2 to get dca to beam spot

It involves the following packages:

CalibTracker/SiStripCommon
RecoMuon/GlobalTrackingTools
RecoTracker/DebugTools
RecoVertex/GaussianSumVertexFit
RecoVertex/KalmanVertexFit
RecoVertex/KinematicFit
SLHCUpgradeSimulations/Geometry
SimTracker/TrackAssociation
TrackingTools/PatternTools
Validation/RecoMuon
Validation/RecoTrack
Validation/RecoVertex

@civanch, @diguida, @StoyanStoynev, @cerminar, @danduggan, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @rcastello, @deguio, @slava77, @mmusich, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @abbiendi, @Martin-Grunewald, @threus, @venturia, @battibass, @makortel, @dgulhan, @jlagram, @cerati, @trocino, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @wmtford, @amagitte, @gbenelli, @appeltel, @gpetruc, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[ktf]

please test
On ven 2 gen 2015 at 22:29 cmsbuild notifications@github.com wrote:

A new Pull Request was created by @Dr15Jones
https://github.com/Dr15Jones (Chris Jones) for CMSSW_7_4_X.

No longer use TrackAssociatorByChi2 to get dca to beam spot

It involves the following packages:

CalibTracker/SiStripCommon
RecoMuon/GlobalTrackingTools
RecoTracker/DebugTools
RecoVertex/GaussianSumVertexFit
RecoVertex/KalmanVertexFit
RecoVertex/KinematicFit
SLHCUpgradeSimulations/Geometry
SimTracker/TrackAssociation
TrackingTools/PatternTools
Validation/RecoMuon
Validation/RecoTrack
Validation/RecoVertex

@civanch https://github.com/civanch, @diguida
https://github.com/diguida, @StoyanStoynev
https://github.com/StoyanStoynev, @cerminar
https://github.com/cerminar, @danduggan https://github.com/danduggan,
@ianna https://github.com/ianna, @mdhildreth
https://github.com/mdhildreth, @cmsbuild https://github.com/cmsbuild,
@Dr15Jones https://github.com/Dr15Jones, @rcastello
https://github.com/rcastello, @deguio https://github.com/deguio,
@slava77 https://github.com/slava77, @mmusich
https://github.com/mmusich, @ktf, @nclopezo
https://github.com/nclopezo can you please review it and eventually
sign? Thanks.
@ghellwig https://github.com/ghellwig, @abbiendi
https://github.com/abbiendi, @Martin-Grunewald
https://github.com/Martin-Grunewald, @threus https://github.com/threus,
@venturia https://github.com/venturia, @battibass
https://github.com/battibass, @makortel https://github.com/makortel,
@dgulhan https://github.com/dgulhan, @jlagram
https://github.com/jlagram, @cerati https://github.com/cerati,
@trocino https://github.com/trocino, @rociovilar
https://github.com/rociovilar, @GiacomoSguazzoni
https://github.com/GiacomoSguazzoni, @rovere, @VinInn
https://github.com/VinInn, @bellan https://github.com/bellan, @wmtford
https://github.com/wmtford, @amagitte https://github.com/amagitte,
@gbenelli https://github.com/gbenelli, @appeltel
https://github.com/appeltel, @gpetruc https://github.com/gpetruc,
@bachtis https://github.com/bachtis this is something you requested to
watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.

—
Reply to this email directly or view it on GitHub
#7036 (comment).

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: e6fa542
I found an error when building:

GSFTrackMaker.cc:(.text+0x31c): undefined reference to `char const* edm::typelookup::className()'
GSFTrackMaker.cc:(.text+0x324): undefined reference to`std::type_info const& edm::typelookup::classTypeInfo()'
tmp/slc6_amd64_gcc491/src/DQM/PhysicsHWW/src/DQMPhysicsHWW/TrackMaker.o: In function `TrackMaker::SetVars(HWW&, edm::Event const&, edm::EventSetup const&)':
TrackMaker.cc:(.text+0x2f9): undefined reference to`char const\* edm::typelookup::className()'
TrackMaker.cc:(.text+0x301): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()'
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc491/src/DQM/PhysicsHWW/src/DQMPhysicsHWW/libDQMPhysicsHWW.so] Error 1
Copying tmp/slc6_amd64_gcc491/src/PhysicsTools/RecoAlgos/src/PhysicsToolsRecoAlgos/libPhysicsToolsRecoAlgos.so to productstore area:
Leaving library rule at PhysicsTools/RecoAlgos
>> Building edm plugin tmp/slc6_amd64_gcc491/src/RecoParticleFlow/PFSimProducer/plugins/RecoParticleFlowPFTrackingSimPlugins/libRecoParticleFlowPFTrackingSimPlugins.so
Copying tmp/slc6_amd64_gcc491/src/JetMETCorrections/TauJet/src/JetMETCorrectionsTauJet/libJetMETCorrectionsTauJet.so to productstore area:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7036/1735/summary.html

[slava77]

+1

for #7036 ffb97c4

based on jenkins: no differences in
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_7_4_X_2015-01-03-1400+7036/5436/validateJR/
or
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_7_4_X_2015-01-03-1400+7036/5436/alternative-comparisons/ (after stripping the timer data).

@nclopezo @ktf
Giulio and David, I'm puzzled by the available set of matrix results:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7036/1737/runTheMatrix-results/ has more tests running than
what shows up in https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_7_4_X_2015-01-03-1400+7036/5436/
However, all of the tests running are appearing in the validateJR

The list of tests is supposedly generated here
https://github.com/cms-sw/cms-bot/blob/29090789fdf4cf320be62bc822e8054856eaceb1/run-ib-comparison-baseline#L13
but the actual list is longer (e.g. 25202 is not in -s)

[davidlange6]

AlCa changes are trivial - so will bypass. Complain if not ok.