Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up likelihood algorithm (parts of code now executed before creation of database object) + updated DBWriter #7057

Merged
merged 19 commits into from Jan 23, 2015

Conversation

tomcornelis
Copy link
Contributor

This pull request includes:

  • Introducing a weight for each likelihood variable, which will be used to get a better performance for high pt jets (see JMAR meeting 11 December 2014)
  • Small optimization of the algorithm when dealing with empty bins in the tails of the pdf's
  • Some clean-up and optimizations on the QGLikelihoodDBWriter code (the input src files and created QGL_v1.db file can be found at /afs/cern.ch/user/t/tomc/public/qgTagger/QGLikelihoodDBFiles)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2015

A new Pull Request was created by @UAEDF-tomc (Tom Cornelis) for CMSSW_7_4_X.

Including weights in the likelihood algorithm + updated DBWriter

It involves the following packages:

CondFormats/JetMETObjects
JetMETCorrections/Modules
RecoJets/JetAlgorithms

@apfeiffer1, @nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @ggovi, @vadler can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @nhanvtran, @schoef, @mariadalfonso, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

}


Q *= std::pow(Qi/Qw, quarkEntry->weight); // Both quarkEntry and gluonEntry have always the same weight
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't the histogram already be pre-filled by (Qi/Qw)**weight values. It seems like it's uniquely defined by var_i -> binIndex?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yes, probably it is possible to move most of this stuff to filling the histogram, I'll look into this

@tomcornelis tomcornelis changed the title Including weights in the likelihood algorithm + updated DBWriter Clean up likelihood algorithm (parts of code now executed before creation of database object) + updated DBWriter Jan 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

Pull request #7057 was updated. @apfeiffer1, @nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @ggovi, @vadler can you please check and sign again.

@tomcornelis
Copy link
Contributor Author

As requested by @slava77 I prefilled the histograms with (Qi/Qw)**weight (including the parts of the code where I take care of empty bins, also helps to get rid of these hard-coded values we had there).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

Pull request #7057 was updated. @apfeiffer1, @nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @ggovi, @vadler can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jan 9, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2015

The tests are being triggered in jenkins.

@tomcornelis
Copy link
Contributor Author

@monttj I guess you have to sign again after this small update

@monttj
Copy link
Contributor

monttj commented Jan 23, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 23, 2015
Clean up likelihood algorithm (parts of code now executed before creation of database object) + updated DBWriter
@cmsbuild cmsbuild merged commit 66d8100 into cms-sw:CMSSW_7_4_X Jan 23, 2015
@tomcornelis tomcornelis deleted the weightedLikelihood branch April 13, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants