New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up likelihood algorithm (parts of code now executed before creation of database object) + updated DBWriter #7057
Conversation
…ns at the extremes of the pdfs
… the grid structure from ROOT to DB, and optimizing the merged categories
…tib, QGL_AK4PFchs_antib
A new Pull Request was created by @UAEDF-tomc (Tom Cornelis) for CMSSW_7_4_X. Including weights in the likelihood algorithm + updated DBWriter It involves the following packages: CondFormats/JetMETObjects @apfeiffer1, @nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @ggovi, @vadler can you please review it and eventually sign? Thanks. |
} | ||
|
||
|
||
Q *= std::pow(Qi/Qw, quarkEntry->weight); // Both quarkEntry and gluonEntry have always the same weight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't the histogram already be pre-filled by (Qi/Qw)**weight values. It seems like it's uniquely defined by var_i -> binIndex?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yes, probably it is possible to move most of this stuff to filling the histogram, I'll look into this
As requested by @slava77 I prefilled the histograms with (Qi/Qw)**weight (including the parts of the code where I take care of empty bins, also helps to get rid of these hard-coded values we had there). |
please test |
The tests are being triggered in jenkins. |
@monttj I guess you have to sign again after this small update |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Clean up likelihood algorithm (parts of code now executed before creation of database object) + updated DBWriter
This pull request includes: