New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unused function. #7064
Drop unused function. #7064
Conversation
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X. Drop unused function. It involves the following packages: RecoTracker/TkDetLayers @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
please test |
the phase 1 tracker code is still a work in progress- maybe we should revisit this one in a few months when that work is fully ported to 7xy.. |
David, there is no problem to remove that function: with the code factorized as it is now there is no need for it anymore. I forgot to remove it myself.
On Jan 7, 2015, at 20:40 , David Lange <notifications@github.commailto:notifications@github.com> the phase 1 tracker code is still a work in progress- maybe we should revisit this one in a few months when that work is fully ported to 7xy.. — |
please test I'm curious why cms-bot didn't listen to Giulio's "please test" |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
This is actually appearing as unused now.