Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused function. #7064

Merged
merged 1 commit into from Jan 8, 2015
Merged

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Jan 7, 2015

This is actually appearing as unused now.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2015

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X.

Drop unused function.

It involves the following packages:

RecoTracker/TkDetLayers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@ktf
Copy link
Contributor Author

ktf commented Jan 7, 2015

please test

@davidlange6
Copy link
Contributor

the phase 1 tracker code is still a work in progress- maybe we should revisit this one in a few months when that work is fully ported to 7xy..

@venturia
Copy link
Contributor

venturia commented Jan 7, 2015

David,

there is no problem to remove that function: with the code factorized as it is now there is no need for it anymore. I forgot to remove it myself.

                                     Andrea

On Jan 7, 2015, at 20:40 , David Lange <notifications@github.commailto:notifications@github.com>
wrote:

the phase 1 tracker code is still a work in progress- maybe we should revisit this one in a few months when that work is fully ported to 7xy..


Reply to this email directly or view it on GitHubhttps://github.com//pull/7064#issuecomment-69078859.

@slava77
Copy link
Contributor

slava77 commented Jan 8, 2015

please test

I'm curious why cms-bot didn't listen to Giulio's "please test"

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Jan 8, 2015

+1

for #7064 8176af5
git grep shows no use other than the definition
letting cms-bot to handle the rest

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 8, 2015
@cmsbuild cmsbuild merged commit 9894b83 into cms-sw:CMSSW_7_4_X Jan 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants