Remove calls to Ref::product from Fireworks #7065
Conversation
Remove the calls to Ref::product from Fireworks. This is motivated by changes in the Ref needed to support the miniAOD format. The removed calls are replaced by adding a function to the EventBase interface that allows getting a product using the ProductID. After the change we explicitly get the ProductID from the Ref and then use the new function in EventBase to get the container product instead of getting the container product directly from the Ref. I extended the unit tests for the Core part of this, but have not tested the Fireworks part of this beyond checking that it compiles (expecting the Fireworks experts to test that, Matevz agreed to do that).
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_4_X. Remove calls to Ref::product from Fireworks It involves the following packages: DataFormats/FWLite @cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
|
Thanks! I will test the change. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Remove calls to Ref::product from Fireworks
Remove the calls to Ref::product from Fireworks.
This is motivated by changes in the Ref needed
to support the miniAOD format. The removed calls
are replaced by adding a function to the EventBase
interface that allows getting a product using the
ProductID. After the change we explicitly get the
ProductID from the Ref and then use the new function
in EventBase to get the container product instead
of getting the container product directly from the
Ref.
I extended the unit tests for the Core part of this,
but have not tested the Fireworks part of this beyond
checking that it compiles (expecting the Fireworks
experts to test that, Matevz agreed to do that).