Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of MvaMET code and tools for miniAOD, cleaning of RecoMET/METPUSubtraction package #7085

Merged
merged 10 commits into from Jan 17, 2015

Conversation

mmarionncern
Copy link

Same as #6922 but rebased on top of CMSSW_7_4_X.

This PR modifies the mva mitigated MET code in order to make it able to run in top of miniAODs. Cleaning and restructuration of the associated code is also done.

Packages involved :
-DataFormats/METReco : auxiliary structure for the pileup mitigated MET algorithm restructuresd for a common approach

RecoJets/JetProducers : pileup mva jet id now able to work in top of miniAOD, mandatory for the mva MET
RecoMET/METPUSubtraction : rewriting of the NoPU and Mva MET code -> clarity and structure improved, mvaMET able to work in top of miniAOD. NoPU will not due to the limited information available on miniAOD, and it is not planned to go further in that direction.
Changes expected :

reco sequence : no change expected so far, plugin of default mva/nopu algorithm at the RECO/AOD or miniAOD level for a next PR
event content : transparent
difference between the mva MET at AOD and miniAOD level : 1% of events slightly different due to the difference of pfCandidate-vertex matching between both format
difference between previous version and new version : slight difference of the mvaMET results compared to the current version in the release, due to how JEC are handled in the pileup Jet Id mva algorithm for the mvaMET (before was internal, now pileup Jet ID mva is independent, and in sync with other use of the pileup mva jet id)
matrix tests are successfull

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

A new Pull Request was created by @mmarionncern for CMSSW_7_4_X.

Integration of MvaMET code and tools for miniAOD, cleaning of RecoMET/METPUSubtraction package

It involves the following packages:

DataFormats/METReco
RecoJets/JetProducers
RecoMET/METPUSubtraction

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @yslai, @TaiSakuma, @ahinzmann, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2015

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 17, 2015

+1

for #7085 ce1863b
tested in CMSSW_7_4_0_pre3 (teste area sign478)
based on the review above;
I xchecked that the last version still runs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 17, 2015
Integration of MvaMET code and tools for miniAOD, cleaning of RecoMET/METPUSubtraction package
@cmsbuild cmsbuild merged commit 882afc5 into cms-sw:CMSSW_7_4_X Jan 17, 2015
@mmarionncern mmarionncern deleted the 74X-MVaNoPuMETForMiniAOD branch November 14, 2016 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants