Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74 Port changes from 73 to 74 #7093

Merged
merged 21 commits into from Jan 17, 2015
Merged

Conversation

alja
Copy link
Contributor

@alja alja commented Jan 8, 2015

This is a merge of development in 73:
git cms-merge-topic alja:cmsShow73-2

@alja alja changed the title Mergemini74 74 Port changes from 73 to 74 Jan 8, 2015
@alja
Copy link
Contributor Author

alja commented Jan 8, 2015

+1

Before creating the PR I save the change is not automatically mergable. Let me know if there are any problems.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_4_X.

74 Port changes from 73 to 74

It involves the following packages:

Fireworks/Calo
Fireworks/Candidates
Fireworks/Core
Fireworks/Electrons
Fireworks/ParticleFlow
Fireworks/Tracks
RecoEgamma/EgammaHLTProducers

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@alja
Copy link
Contributor Author

alja commented Jan 8, 2015

What is a test for merge ?
I have tried git cms-merge-topic and this one worked without an error.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

-1
@alja This pull request cannot be automatically merged, could you please rebase it?

@Martin-Grunewald
Copy link
Contributor

Hi @alja
In your PR, get rid of your changes to
RecoEgamma/EgammaHLTProducers/src/EgammaHLTRechitInRegionsProducer.cc
these are already in 74X and thus cause (some of?) the merge conflicts (and also requires
HLT signature for your PR which should not be the case anyway).

@alja
Copy link
Contributor Author

alja commented Jan 9, 2015

Thanks Martin,
I have rebased to 74 and don't see RecoEgamma changes anymore.

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2015

Pull request #7093 was updated. @cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants