Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consume & getByToken #711

Merged
merged 1 commit into from Sep 6, 2013
Merged

consume & getByToken #711

merged 1 commit into from Sep 6, 2013

Conversation

yiiyama
Copy link
Contributor

@yiiyama yiiyama commented Sep 4, 2013

Updating ECAL DQM EDAnalyzers to getByToken scheme

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2013

A new Pull Request was created by @yiiyama (Yutaro Iiyama) for CMSSW_7_0_X.

consume & getByToken

It involves the following packages:

DQM/EcalCommon
DQM/EcalEndcapMonitorModule
DQM/EcalBarrelMonitorModule
DQMOffline/Ecal
DQM/EcalEndcapMonitorTasks
DQM/EcalBarrelMonitorTasks
DQM/EcalPreshowerMonitorModule

@rovere, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor

nclopezo commented Sep 4, 2013

Hi,

I ran the tests on top of CMSSW_7_0_X_2013-09-04-0200, all tests passed:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/384/console

you can see the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/384

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2013

The following categories have been signed by @rovere: DQM

@cms-git-dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

nclopezo added a commit that referenced this pull request Sep 6, 2013
@nclopezo nclopezo merged commit 0666587 into cms-sw:CMSSW_7_0_X Sep 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants