Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim threadsafe dqm #7112

Merged
merged 2 commits into from Jan 12, 2015
Merged

Fastsim threadsafe dqm #7112

merged 2 commits into from Jan 12, 2015

Conversation

lveldere
Copy link
Contributor

Migration to thread-safe DQMstore

  • code in FastSimulation/CaloRecHitsProducer/test/ is no longer relevant and was removed
  • DQMstore no longer used in FastSimulation/Calorimetry and FastSimulation/ShowerDevelopment
    (the affected classes are used in a producer, DQMstore is not available in producers)
  • FastSimulation/TrackingRecHitProducer/test/SiPixelRecHitsInputDistributionsMaker.*
    migrated to thread-safe DQMstore

zero regression expected

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_4_X.

Fastsim threadsafe dqm

It involves the following packages:

FastSimulation/CaloRecHitsProducer
FastSimulation/Calorimetry
FastSimulation/ShowerDevelopment
FastSimulation/TrackingRecHitProducer

@cmsbuild, @civanch, @nclopezo, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 12, 2015
@cmsbuild cmsbuild merged commit 8c75583 into cms-sw:CMSSW_7_4_X Jan 12, 2015
@lveldere lveldere deleted the fastsim-threadsafe-dqm branch January 14, 2015 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants