Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCAL V6 geometry Z partitions #7140

Merged

Conversation

vandreev11
Copy link
Contributor

@bsunanda, @pfs, @lgray New HGCAL V6 geometry Z partition for HE backing calorimeter as 6 and 6 layers

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vandreev11 for CMSSW_6_2_X_SLHC.

HGCAL V6 geometry Z partitions

It involves the following packages:

Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@vandreev11
Copy link
Contributor Author

@mark-grimes, @fratnikov I wonder why it is not yet merged. Thanks

@fratnikov
Copy link

Two reasons:

  1. this is XML, so doesn't affect nightly builds. v6 is not in RelVals.
    Thus this waits until further progress with v6
  2. modified file doesn't look specific to v6: is v5 intact with these PR?

@vandreev11
Copy link
Contributor Author

@fratnikov 2. v5 is in tact, in the sense that v5 geometry is frozen and is not affected by v6. Particle Flow needs to be synchronized.

@fratnikov
Copy link

merge
This affects nothing than v6 HGCAL indeed

cmsbuild added a commit that referenced this pull request Jan 27, 2015
@cmsbuild cmsbuild merged commit 1db10f2 into cms-sw:CMSSW_6_2_X_SLHC Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants