Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT cosmic reco switch to meantimer #7177

Merged
merged 1 commit into from Jan 17, 2015
Merged

Conversation

ptraczyk
Copy link
Contributor

This is a fix for #7044, this one commit was missing there. The validation plots attached in that PR reflect the situation WITH this commit.
This completes the migration of offline DT reconstruction to the Meantimer pattern recognition algorithm, the Reconstruction and ReconstructionCosmics seqences now use the same DT algorithm for cosmics.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ptraczyk (Piotr Traczyk) for CMSSW_7_4_X.

cfg file fix

It involves the following packages:

RecoLocalMuon/Configuration

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@bellan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

-1
Tested at: a7990f5
When I ran the RelVals I found an error in the following worklfows:
1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7177/1890/summary.html

@ptraczyk
Copy link
Contributor Author

but thats not me, the same error is present without my commit

On Thu, Jan 15, 2015 at 9:17 PM, cmsbuild notifications@github.com wrote:

-1
Tested at: a7990f5
a7990f5
When I ran the RelVals I found an error in the following worklfows:
1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log

you can see the results of the tests here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7177/1890/summary.html


Reply to this email directly or view it on GitHub
#7177 (comment).

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 17, 2015

Piotr, please update the subject of the PR to indicate it's for DT cosmic segment reco
(cfg file fix) is not clear enough for self-documentation

@ptraczyk ptraczyk changed the title cfg file fix DT cosmic reco cfg file fix Jan 17, 2015
@ptraczyk ptraczyk changed the title DT cosmic reco cfg file fix DT cosmic reco switch to meantimer Jan 17, 2015
@ptraczyk
Copy link
Contributor Author

ok, I made it more explicit

@slava77
Copy link
Contributor

slava77 commented Jan 17, 2015

+1

for #7177 a7990f5
tested in CMSSW_7_4_0_pre3 (test area sign487)

As expected, changes affect only the cosmic scenario.
Changes in monitored quantities start from dtSegments: nDOF
Only a few barrel muon distributions are visibly changing, (other monitored quantities are not changing shapes in a noticeable way): STA chi2, time uncertainties

CPU consumed by dt4DSegments goes up from 4.46094 ms/ev to 49.2779 ms/ev, based on wf 4.22 RunCosmics2011A, from 160960 (10K events run). This is a 10% increase in reco step. Shouldn't be a big deal here (the algorithm is more complex).

(thank you for changing the subject to the more descriptive).

below are some plots from 7.0 (cosmic MC)
dt4DSegments chi2

all_sign488vsorighistat_cosmicswf7p0c_mindtchamberiddtrecsegment4dsownedrangemap_dt4dsegments__reco_obj_collection__data__chi2 99_99

all_sign488vsorighistat_cosmicswf7p0c_recomuons_muons__reco_obj_time_timeatipinouterr

all_sign488vsorighistat_cosmicswf7p0c_recomuons_muons__reco_obj_time_timeatipinouterr

some from data (wf 4.22)
about 3% of muons get "reassigned" to be in the barrel instead of endcap
wf4p22_sta_chi2
wf4p22_sta_chi2_ecap
wf4p22_meseed_theta

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 17, 2015
DT cosmic reco switch to meantimer
@cmsbuild cmsbuild merged commit 6903e57 into cms-sw:CMSSW_7_4_X Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants