New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT cosmic reco switch to meantimer #7177
Conversation
A new Pull Request was created by @ptraczyk (Piotr Traczyk) for CMSSW_7_4_X. cfg file fix It involves the following packages: RecoLocalMuon/Configuration @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
-1 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log 25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log you can see the results of the tests here: |
but thats not me, the same error is present without my commit On Thu, Jan 15, 2015 at 9:17 PM, cmsbuild notifications@github.com wrote:
|
Piotr, please update the subject of the PR to indicate it's for DT cosmic segment reco |
ok, I made it more explicit |
+1 for #7177 a7990f5 As expected, changes affect only the cosmic scenario. CPU consumed by dt4DSegments goes up from 4.46094 ms/ev to 49.2779 ms/ev, based on wf 4.22 RunCosmics2011A, from 160960 (10K events run). This is a 10% increase in reco step. Shouldn't be a big deal here (the algorithm is more complex). (thank you for changing the subject to the more descriptive). below are some plots from 7.0 (cosmic MC) some from data (wf 4.22) |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
DT cosmic reco switch to meantimer
This is a fix for #7044, this one commit was missing there. The validation plots attached in that PR reflect the situation WITH this commit.
This completes the migration of offline DT reconstruction to the Meantimer pattern recognition algorithm, the Reconstruction and ReconstructionCosmics seqences now use the same DT algorithm for cosmics.